Git Product home page Git Product logo

Comments (8)

r--s avatar r--s commented on June 24, 2024

It should be handled on lb level, as we are already adding x-forwareded-for, and it's being stripped of by apache rpaf module.

from bud.

arunoda avatar arunoda commented on June 24, 2024

It can't handled by the LB level. Then LB thinks it gets the request from bud not from the client.
I'm asking whether is BUD going to maintain a proxy chain in the x-forwarded-for or it will replace it with the existing x-forwarded.

This is because, something our nodes directly handles client requests and sometimes they get requests from a LB.

node-http-proxy does this well. But we don't want it to handle SSL/TLS termination.

from bud.

r--s avatar r--s commented on June 24, 2024

I'm sorry, I've misstook project for different one. You are right.

from bud.

indutny avatar indutny commented on June 24, 2024

@arunoda I'm afraid bud we'll just add extra header line to the first request. So technically, first request will have proper proxy chain, but you'll need to prepend first address from the chain manually to the all further requests on the connection.

Please note that X-Forwarded-For feature does not parse http.

from bud.

arunoda avatar arunoda commented on June 24, 2024

I see. So, it'll possible to have multiple actual clients connection behind a one BUD socket connection.
(May be that's okay, we can live with it)

We are building a kind of rate limiting system, needs client ip for part of it's logic.

from bud.

indutny avatar indutny commented on June 24, 2024

@arunoda not just Bud, this is quite normal for HTTP: one TCP socket - multiple requests. Anyway, this should be easy to handle in io.js/node.js.

Assuming resolved?

from bud.

arunoda avatar arunoda commented on June 24, 2024

Yeah got it. We can mark it as resolved.

Thanks.

from bud.

indutny avatar indutny commented on June 24, 2024

Thank you!

from bud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.