Comments (5)
Yeah, we need a way to make the formatter more customizable. I like the idea of setting up functional options for the LogFmtFormat constructor and letting you pass those in. So the API might look like:
func LogFmtFormat(opts ...FormatOption)
And usage:
// default
fmtr := log.LogFmtFormat()
// customized formatter
fmtr := log.LogFmtFormat(
log.WithTimeFormat(func(time.Time) string {
return "Hammer Time!"
}),
log.WithMessagePadding(10),
log.WithTimelKey("time"),
log.WithLevelKey(""), // empty string means omit
)
This would address #84 and some other issues we closed in the past.Maybe we could even share some of the options with the JSONFormatter. Thoughts?
@ChrisHines thoughts on this API? I think it would get us some flexibility in custom formatting we were always missing. I wonder if this is a better way to allow folks to define custom names for t
, lvl
, and msg
keys instead of the RecordKeyNames
that we eventually settled on
from log15.
@grahamking started down the path of functional options in #60 but abandoned it for a custom formatter the better fit his needs.
The log.WithTimeFormat
approach is interesting because it doesn't assume you are using time.Format
.
from log15.
interesting. @kevinburke or I might take a stab at resurrecting that approach. do you like the way that worked out for StdlibAdapterOption
in go-kit/log?
from log15.
I don't use StdlibAdapter
much and I didn't write it either, credit for that idea goes to @peterbourgon, but I do like how functional options work for this sort of thing.
from log15.
Instead of functional style options like above why not pass in an options struct?
In the struct the user can specify only the options they need and rest all is default. I have seen this approach in the Kafka go library
Examples
https://pkg.go.dev/github.com/segmentio/kafka-go?utm_source=godoc#Writer
https://github.com/segmentio/kafka-go/blob/v0.4.32/reader.go#L622
from log15.
Related Issues (20)
- Add Illumos support HOT 1
- support log rotate HOT 3
- Expose the runtime.Callers skip HOT 1
- tag a new release HOT 1
- v2.12 Build Issues HOT 3
- Support for a kv-generating interface on log arguments
- Normal log15.Root() not colorized on Cygwin
- logfmt/json keys for msg/lvl/t are hard-coded HOT 3
- Allow logging in UTC HOT 2
- Use Semantic Version Tags compatible with the new Go modules HOT 1
- Please add a go.mod file HOT 1
- make NetHandler able to log to an URL?
- No way to close files opened when a new FileHandler is created.
- Default Lvl is LvlCrit HOT 1
- proposal: add Fatal() HOT 1
- Test failure while building v2.15
- Use semantic versioning to satisfy `go mod`
- Is this library maintained? HOT 3
- CallerFileHandler should include package name
- Different outputs for different functions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from log15.