obscured cartography not applying to observations of threatened taxa about inaturalistapi HOT 2 CLOSED

This was fixed with the first two file changes in 3c90597 . It is not stripping private_location field out of the grid.json (it is obfuscating the data), but this is actually good because we need that information in the front end. What we need on the front end is some indicator of wether or not an observation is to be represented by a circle or flag marker. Since the tileserver has to check both geoprivacy and presence of private coordinates to make that determination, the front-end code needs the same information to make the exact same determination.

To be clear - we're either returning private_location: "" to represent no private location, or private_location: "[object Object]" to represent the presence of a private location. We never send any actual private location data other than presence/absence.

We could have some step in-between fetching the data from ES and rendering the .grid.json to create some kind of "is_obscured" boolean (alternatively we could add that to the ES index itself), but currently elasticmaps isn't set up to have any logic in between fetch results and rendering. So there are various things we can do, though I do worry a little about slowing down the tileserver with more logic. If we really wanted to change it, I'd vote for adding a field to ES which would make the logic clearer for both the tileserver styles and the UTFGrid interaction offsets.

from inaturalistapi.

I'm fine with the way we have it. Not ideal, but workable, and not revealing anything we shouldn't.

from inaturalistapi.