Git Product home page Git Product logo

Comments (7)

budowski avatar budowski commented on July 18, 2024

@loarie - which part is underlined? The email address?
Also, how do we detect if a user is unconfirmed? One of the fields in the /users/me API response?

from inaturalistandroid.

kueda avatar kueda commented on July 18, 2024

A user is unconfirmed if the users/me response has a user where confirmed_at exists and is not null.

If @loarie wants the user to be able to resend the confirmation email, you're going to have to use the undocumented /users/resend_confirmation endpoint, which requires auth and resends the email to the authenticated user.

FWIW, I think it's very confusing that the banner doesn't match the screenshot, and that the banner text implies that an email will be sent but tapping the banner just opens a modal that does nothing.

from inaturalistandroid.

loarie avatar loarie commented on July 18, 2024

@abhasinat do we need the underlined link in the banner to open a modal (analogous to what happens in the existing modal on profile) or can the underlined link in the banner just send the email directly?

from inaturalistandroid.

abhasinat avatar abhasinat commented on July 18, 2024

Yep, here's the text we can use:

Yep, the intent was to make it more pervasive and annoying to encourage a user to confirm their email. We also decided to change the text to indicate that a confirmation email would be resent (see below). Clicking the banner should open a modal with the text: "Would you like to resend a confirmation email to [email address]?" with the buttons "Resend Email" and "Cancel"

After an email is sent, there should be a modal with the text "Email sent! Please click the link in the email." with a single CTA "Ok"

Mobile Announcement - Confirmation

We can also do an underline of the last line if that's better, though the entire banner should be clickable:
Android Announcement - Confirmation

from inaturalistandroid.

loarie avatar loarie commented on July 18, 2024

thanks for adding this @budowski budowski - is this issue now closed?

from inaturalistandroid.

budowski avatar budowski commented on July 18, 2024

Assuming it's looking good for you? @tiwane ? @abhasinat ?

from inaturalistandroid.

loarie avatar loarie commented on July 18, 2024

I tested this on the old Huawei and it works great. I had to close/reopen the app for the banner to go away after confirming but I don't think thats a big deal. I approve closing this if you're comfortable doing so

from inaturalistandroid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.