Comments (8)
We should implement default illumination and detection devices separately and an additional PA device generator that takes one illumination and one detection device from our predefined devices and generates the respective PA device.
This way, users have a lot more choices to construct a PA device "on the fly". Also, it is more elegant to just simulate the optical or acoustic models without having to choose a PA device when there is no PA effect involved.
Specific products like the MSOT devices can still stay the way they are.
from simpa.
It might be worth considering creating new classes for the DetectionGeometry
and IlluminationGeometry
and having a PADevice
class that is a combination of the two?
The settings file would then be assigned the PADevice instance, where one of the two could be None
thus achieving what you propose?
from simpa.
Potentially found an "off-by-one" error in the Python to MATLAB conversion when defining the detector positions. MATLAB indexing starts with 1, not 0, which we apparently did not consider previously.
from simpa.
Work on this will also fix #49.
from simpa.
Linear and curved detection geometries are now implemented.
from simpa.
Implemented all previously available devices.
Custom devices that combine the illumination and detection geometries can now easily be added.
@kdreher I propose we discuss the current implementation, integrate it into develop and start adding more detection and illumination geometries in a new task.
from simpa.
Will work towards #11, #19, and #12 within these changes.
from simpa.
Opened new task #61 for the addition of further geometries that should be in SIMPA.
Closing, as it is integrated in #57
from simpa.
Related Issues (20)
- Wrong error message in curved_array.check_settings_prerequisites
- [1, 1, 1] origin used in MCX HOT 1
- Simpler minimal optical simulation example
- Custom time spacing is not considered in DAS reconstruction convenience function
- Update pre-commit hook checking for license text to only consider the license and not the specific copyright information
- Possible Bug: Rot90 in kwave adapter HOT 1
- Add property field for refractive index n
- manual KWaveConvenienceFunction test fails
- acoustic forward process
- Torch tensors do not accept None type (ERROR in segmentation based volume generation)
- error('t_array must be evenly spaced.') raises in makeTime for sinlge precision
- Distinguish between artery and vein blood vessels
- Add more docstrings and type hints in simpa.utils.libraries.structure_library
- slit_illumination and pencil_array_illumination HOT 1
- Add a planar illumination geometry HOT 2
- Fix file_in_simpa_home test
- Implement a function for creating a generic tissue from optical parameters
- numpy operations in vessel structure not gpu supported
- MCXAdapterReflectance does not use anisotropy for simulation HOT 8
- Floating point rounding error for M1 Mac HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simpa.