Comments (6)
It looks like there is already some progress on this with sigpy mikgroup/sigpy#123 and mikgroup/sigpy#126
from pypulseq.
@wtclarke Thanks for reporting this. We can update the sigpy version as soon as they merge the fix and release it.
I agree with your suggestion. I have never used CI, would you be willing to open a PR for a .yml file for this project? Is that even how it works? 😄
from pypulseq.
I am currently preparing a pypulseq hands-on session for this friday and installing PyPulseq is really a pain in the a**
Can we please push a hotfix to master and release a version 1.40.post1?
The only thing we have to do is change the dependencies from "sigpy==0.1.23"
to "sigpy>=0.1.25"
We can still discuss to remove the sigpy dependency completely in the future, but for now we need a quick solution IMO!
EDIT:
the sigpy developers merged the fix in May, but didn't release it yet. Thus, changing to "sigpy>=0.1.25"
is NOT enough yet.
A temporary option would be to change the dependency to git+https://github.com/mikgroup/sigpy.git
, but this would prohibit a release to PyPi. Still it might be the best option for the moment?
from pypulseq.
This is fixed with the merge of #148
from pypulseq.
Is there a reason why we ask for sigpy==0.1.23 and not >= 0.1.23 ?
We should at least push a fix for the imcompatibility problem to the dev branch, but I could imagine that a lot of users that are not on GitHub get frustrated due to this issue and maybe even stop using PyPulseq...
So imo we should fix this and release v1.40.post1 as soon as possible!!!
from pypulseq.
@schuenke We can do that. Or, we can remove the sigpy dependency, as we are only using a couple of functions from a single file. With appropriate copyright notice of course. How about it?
from pypulseq.
Related Issues (20)
- Arguments of make_block_pulse are highly confusing HOT 3
- make_trapezoid with just flat_area fails HOT 6
- Conda Package for Pypulseq HOT 5
- PyPulseq requires GPU compute (cuPy) on Google Colab HOT 3
- KeyError When Reading .seq File generated from MATLAB pulseq 1.4.0 in pypulseq 1.4.0 HOT 5
- Pypulseq ignores BlockDurationRaster Definition in file
- Compatibility with Pulseq 1.3.1 broken HOT 1
- Feature: Sequence `install`
- Sigpy pulses can not be added to sequence HOT 1
- add_blocks interpolation issue HOT 2
- "Identical" shapes not found in event_lib HOT 4
- Numpy float error when importing pypulseq HOT 1
- Change default branch back to main HOT 1
- Incompatibility of sigpy dependency with scipy 1.14.0 and numpy 2.0 HOT 1
- block duration rounding assertion test HOT 1
- Rounding error in add_gradients leads to incorrect gradient waveforms HOT 3
- Sub-microsecond ADC delays are dropped without notification when exporting to .seq file HOT 3
- calculate_kspace_PP error with EPI sequence HOT 2
- Define common code style (Linting/Formatting)
- Introduction of custom variables HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pypulseq.