Git Product home page Git Product logo

Comments (4)

paulstraw avatar paulstraw commented on September 25, 2024

Since we're going to bump to 1.0.0 anyhow with the Client#sign_path removal, would it make sense to completely remove :secure in that version? That way it's a clean break. I'd like to split it into :use_https and :sign_urls.

from imgix-rb.

kellysutton avatar kellysutton commented on September 25, 2024

I think :use_https (defaulted to true) makes sense.

The existence of a :token should act as the conditional as to whether or not sign a URL. That is, if a :token is not specified, URLs do not get signed. What do you think?

from imgix-rb.

paulstraw avatar paulstraw commented on September 25, 2024

I can dig it, but maybe rename :token to :secure_url_token to be a bit more clear, as well as match the copy in the app?

from imgix-rb.

kellysutton avatar kellysutton commented on September 25, 2024

Yep. Sounds good.

from imgix-rb.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.