Comments (4)
Since we're going to bump to 1.0.0
anyhow with the Client#sign_path
removal, would it make sense to completely remove :secure
in that version? That way it's a clean break. I'd like to split it into :use_https
and :sign_urls
.
from imgix-rb.
I think :use_https
(defaulted to true
) makes sense.
The existence of a :token
should act as the conditional as to whether or not sign a URL. That is, if a :token
is not specified, URLs do not get signed. What do you think?
from imgix-rb.
I can dig it, but maybe rename :token
to :secure_url_token
to be a bit more clear, as well as match the copy in the app?
from imgix-rb.
Yep. Sounds good.
from imgix-rb.
Related Issues (17)
- feat: optionally disable path encoding HOT 6
- chore(test): more test dependencies to a separate group in Gemfile HOT 2
- feat: customize variable qualities
- feat: customize target Device Pixel Ratios
- Asset fingerprint gets URL-encoded and breaks image filenames HOT 2
- Does this library support purging images from cache? HOT 6
- Why does it alway return a secure URL? HOT 2
- Fix `?&s=` when signing URL without other params
- Remove `Client#sign_path`
- API options not supported, some error out HOT 2
- Expires query param? HOT 3
- Support images with query strings on them HOT 6
- Upgrading from 0.3.5 to 1.2.2 HOT 2
- Make signature optional HOT 4
- Introduce Rubocop HOT 2
- Support adding params joined with - HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imgix-rb.