Comments (3)
From what I've seen in the PHP community, it's most common not to commit the lock file. As seen in my examples above.
Besides, this library has very few dependencies compared to most. Both PHPUnit and the Laravel team are respectable developers, and handle the semantic versioning very well. As long as the version definitions in composer.json
is strict enough (and I believe they are), I don't think there will be any problems. 😊
You could configure CI to run twice as well. Once with the latest versions, and once with the lowest supported versions according to composer.json
.
--prefer-lowest: Prefer lowest versions of dependencies. Useful for testing minimal versions of requirements[...]
Composer flag--prefer-lowest
matrix:
php: ['8.0', 8.1, 8.2]
stability: [prefer-lowest, prefer-stable]
from imgix-php.
I like the CI suggestion a lot, and your explanation regarding relying on composer.json
makes sense to me.
from imgix-php.
Hey @adevade, thanks for opening the issue and the PR.
I can see why committing the lock file is inconvenient.
I would like to keep dependencies pinned as that keeps future maintainers and CI from inadvertently updating a dependency, making the build output slightly different from the distributable. But to your point, the Composer docs explicitly state committing the lock file is optional and probably not needed.
For your library you may commit the composer.lock file if you want to. This can help your team to always test against the same dependency versions. However, this lock file will not have any effect on other projects that depend on it. It only has an effect on the main project.
In your opinion, do you see it as an insignificant risk to potentially have dependency versions vary between maintainers so long as CI is always pulling in the latest dependency?
from imgix-php.
Related Issues (20)
- Add option to exclude library param HOT 5
- Mangled src URLs HOT 1
- unable to add imgix-php files to git HOT 4
- Building a URL with multi-dimensional array HOT 2
- Describe an easy example for purge images in PHP HOT 6
- Regression in version 1.2 HOT 1
- Umlaut & signed URLs not working HOT 5
- Drupal 7 with Imgix HOT 2
- encoding URLs incorrectly for characters "(" and ")" HOT 4
- Multi-line Text & Overlays with the Typesetting Endpoint HOT 1
- Image width and height on-the-fly HOT 4
- Tag a new release with latest changes in master HOT 1
- h-parameter scaling in createSrcSet HOT 6
- feat: optionally disable path encoding HOT 3
- feat: customize variable qualities
- feat: customize target Device Pixel Ratios
- Release a new major version (v4.0) with PHP 8.0+ support only HOT 5
- Add a coding style, with an automatic formatter HOT 4
- Suggestion: Open development branch for accepting PRs to next major version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imgix-php.