Git Product home page Git Product logo

Comments (6)

mnwright avatar mnwright commented on July 27, 2024

You are right, it is currently not saved. I think we can add it as you suggest, we just need to add something for the x/y interface (where there might be no name).

from ranger.

talegari avatar talegari commented on July 27, 2024

IMHO for x/y interface, dependent.variable.name should be NULL as we are not getting it either from a named argument or a named datastructure (such as a dataframe).

from ranger.

jemus42 avatar jemus42 commented on July 27, 2024

For the xy/ interface we could default to using deparse(substitute(y)), no? Taking the name of the object might be more informative than a NULL

from ranger.

mnwright avatar mnwright commented on July 27, 2024

But then it would be an object name and not a variable name, right? I think people want to use dependent.variable.name to subset data later, which wouldn't make sense with x/y.

from ranger.

jemus42 avatar jemus42 commented on July 27, 2024

Ah, sure - I was primarily worried about having default behavior that doesn't yield NULL, and assumed that x/y interface would be used in a context where target and features are in distinct objects anyway, hence falling back to object names is the next best thing to having variable names. Obviously, if y = somedata$sometarget then that point is moot, kind of.

from ranger.

mnwright avatar mnwright commented on July 27, 2024

Thanks, merged #698.

from ranger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.