Comments (8)
+1
from deck.js.
👍
from deck.js.
What is the suggestion here? To include a thin web server w/ deck.js? To not use replaceState
? Document this as a warning?
from deck.js.
I will confess up front to not having looked at how you use replaceState()
, therefore not knowing offhand the implications of removing it, but it seems like Chrome has now made it a dead letter, and not using it is the right thing to do. Unless this kind of API retreat becomes a massive trend and JavaScript from file://
URLs becomes practically impossible, I think the thin web server option is too complex. It's an extra moving part that will be a pain in the butt across platforms, having its own dependencies, etc.
If the alternatives to replaceState()
end up ballooning history in weird ways or being unacceptable for other reasons, that's cool, but absent compelling considerations there I think nuking it is the right thing to do.
from deck.js.
Workaround:
Open deck.js, go to line ~340 and change
window.history.replaceStats({}, "", hashPath);
to
try{window.history.replaceStats({}, "", hashPath);}catch(err){if (!err.message.startsWith("Failed to execute 'replaceState' on 'History'")){throw new Error(err.message);}}
Note that it is a nasty fix. Better would be to handle only this specific error (but current chrome won't work with "instanceof SecurityError") and in case of any other error just throw it through...
from deck.js.
+1
from deck.js.
@tlberglund @sarperlman Can this be closed?
from deck.js.
Well, we don't have write access to this repo, so we can't close it ourselves, but good catch all the same! This was fixed in Chrome at some point in the past few months.
from deck.js.
Related Issues (20)
- All my decks are hosed with Firefox 36.0.4 HOT 1
- Space bar and Backspace keys work like Left and Right HOT 2
- option for disabling hash navigation HOT 6
- Remove Donation section of Readme
- Maximum number of pages HOT 3
- Sample doesn't work HOT 1
- Swiping not possible in IE11
- vcenter does not work with scale HOT 2
- Script and plugin loading order HOT 2
- Demo site does not exist HOT 1
- How to prevent a slide from becoming blurry when moving to next slide?
- Overview of "menu" extension cannot be scrolled in Firefox
- menu extension : cannot scroll
- Incorrect syntax for aria roles
- New release?
- HTTPS and maybe own domain?
- Include the deck.js in the main index.pug file ..is it possible
- Current project status HOT 2
- <dl> tag not supported?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deck.js.