Git Product home page Git Product logo

Comments (3)

Shnatsel avatar Shnatsel commented on September 27, 2024

This seems like a pretty large undertaking, and would be difficult to design in one go and without prototyping first. But long-running branches suck because of editing conflicts.

How about we get started on this in-tree, but gate the whole thing behind a non-default feature such as metadata-I-know-this-is-unstable ? This will let us prototype in-tree and get initial feedback from the interested users, without mega-branch that will burn out the authors with conflicts.

from image.

Shnatsel avatar Shnatsel commented on September 27, 2024

roxmltree could be a good candidate for XML parsing. It was written for resvg because other XML parsers were too complex and bloated. It has zero dependencies, 100% safe code, and has been extensively tested as part of resvg.

That doesn't solve writing XMP because "ro" stands for "read-only". But I guess we can feature-gate the functions relying on the parsed XML (if any) and let the users bring their own XML parser?

from image.

fintelia avatar fintelia commented on September 27, 2024

Yeah, that could be helpful if we ever need to parse XMP metadata. Though I think we could actually implement a bunch of the basic functionality without ever having to do that. Just having a way for the user to get the blob of XML bytes and telling them to figure out how to parse it if they care what's inside would probably be enough to start with.

I like the idea of experimenting behind a feature flag. For the ImageDecoder::{exif_metadata, xmp_metadata} (and maybe orientation) methods, I think the API is clear enough that we could skip that step, but for the bigger pieces it would be a nice assurance that we aren't going to back ourselves into a corner right away.

from image.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.