Git Product home page Git Product logo

Comments (6)

fintelia avatar fintelia commented on September 26, 2024 1

So I guess the weird thing here is that you want to iterate over the rows of the image in parallel, and then for each row iterate over the pixels sequentially. We already have support if you want to do both sequentially (enumerate_rows_mut().map(|row| ...)) or both in parallel (par_enumerate_pixels_mut).

I guess I don't see an issue with adding a par_enumerate_rows{_mut} that would let you enumerate the pixels sequentially. Though it makes me wonder if all the rows iteration methods should really have Item = &[P] / Item = &mut [P] rather than in producing iterators themselves, so that the user had the option of iterating or just doing random accesses

from image.

JSorngard avatar JSorngard commented on September 26, 2024

If this were implemented with the types in this crate I would map each row to an EnumeratePixels(Mut) instead of a normal slice iterator.

from image.

JSorngard avatar JSorngard commented on September 26, 2024

I think I personally would prefer that API as it would allow, as you say, the user to call either iter or par_iter on the slices, which gives more options for how to iterate over the data.

I think changing the sequential versions of the row iterators would be a breaking change though right?

from image.

fintelia avatar fintelia commented on September 26, 2024

It would even let you call chunks or windows or other fancy methods on it. But yeah, it would be a breaking change for the sequential row iterations and sightly awkward to have inconsistent behavior if we didn't match for the parallel iterations

from image.

JSorngard avatar JSorngard commented on September 26, 2024

I think it is a good idea to have them be consistent, since then you can just add a par_ in front and magically have parallelism. But it also sounds like it would be a very good idea to change the row iterators to return slices in the next major version.
These two things together mean that either the parallel versions should be implemented to be consistent now and then change both them and the serial ones in the next major version, or don't implement them until the next major version where the serial ones are changed.

from image.

typedrat avatar typedrat commented on September 26, 2024

I would love this right now! The specific use case I have for it is maintaining per-core cache coherency and allowing SIMD to be used more easily.

from image.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.