Comments (4)
Portable SIMD isn't available in stable Rust yet, so any use would have to be behind an unstable feature flag as we did for the png crate. (And even once it stabilizes we'd still have to wait until it was present in our MSRV before enabling it by default.)
The other consideration is that manually using SIMD has to be "worth it". The Rust compiler is very good at auto-vectorization so that should always be attempted first. And even when that's not possible, there has to be an impactful enough performance difference to justify making the code more complex.
from image.
sounds good, for now I'll avoid using it, but I'll try to fix up the code so that it's more amenable to optimization.
Right now I'm running the code in a hot path and I've found it to be slow,
I've also chucked it into godbolt and it's about 300 lines of asm with -O
, so I'll try to shrink it down
from image.
@JulianKnodt note that -O
on godbolt does not optimize as much as cargo build --release
does. You need to pass -Copt-level=3
to get the high optimization level that includes auto-vectorization.
I've been banging my head for two hours on why the compiler won't autovectorize something, and it turned out that I was using -O
on godbolt. I hope I am not too late to spare you this fate!
from image.
ah I didn't realize that, but I've updated the interpolation code to be more efficient in the unoptimized case, which is probably still good in the vectorized case: #2078
from image.
Related Issues (20)
- SVG image "format could not be determined" HOT 4
- JPG image first two bytes are not an SOI marker HOT 1
- Panic when checking broken tiff file HOT 1
- Freeze when trying to open and save jpg and webp files HOT 3
- Random crashes when decoding exr file HOT 2
- `image` still depends on `jpeg-decoder` through the `tiff` crate
- `rayon` is included in the dependency tree even when the `rayon` feature is disabled when `ravif` feature is enabled HOT 1
- The documentation on `crop()` is confusing HOT 1
- Add in-place versions of all rotation operations HOT 1
- `DynamicImage::crop()` is slow because `to_image()` is slow HOT 1
- Cropping API doesn't check bounds, easy to misuse HOT 7
- EnumeratePixels and EnumerateRows should implement DoubleEndedIterator HOT 3
- Implement a `rows()` iterator on `SubImage` HOT 6
- how to convert a rgbaImage to opencv's Mat?
- Regression: Hot lib reload, unable to find __rust_alloc. HOT 6
- Increased generation loss in JPEG encoder HOT 1
- Broken link in docs HOT 2
- Should the next major release be 1.0? HOT 2
- Detect alpha on jpeg HOT 2
- Alternate versions of the crates which allow regular breaking changes HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from image.