Support RLE encoding for TGA about image HOT 6 CLOSED

The API could use DynamicImage::write_with_encoder. Analogous to how you can control compression parameters for JPEG:

let encoder = JpegEncoder::new_with_quality(&mut writer, 95);
img.write_with_encoder(encoder)?;

That said, TGA compression is not great by modern standards. If you can use a different format, you'll likely get better compression

from image.

That said, TGA compression is not great by modern standards. If you can use a different format, you'll likely get better compression

It's not my choice, unfortunately 😐

The API could use DynamicImage::write_with_encoder

So a possible API could be:

pub struct TgaEncoder<W: Write> {
    writer: W,
    use_rle: bool,
}

impl<W: Write> for TgaEncoder<W> {
  // ... new

  pub fn with_rle(w: W) -> TgaEncoder<W> {
    TgaEncoder {
      writer: w,
      use_rle: true,
    }
  }

  pub fn use_rle(mut self) -> TgaEncoder<W> {
    self.use_rle = true;
    self
  }
}

let encoder = TgaEncoder::with_rle(&mut writer);
// or
let encoder = TgaEncoder::new(&mut writer).use_rle();
img.write_with_encoder(encoder);

from image.

Yeah. Though, I'd probably suggest calling it "rle" or "compression" or something like that. Even the uncompressed version still counts as "encoding".

Another question is whether it makes more sense to add the new option as a constructor ("with_rle") or as a setter ("set_rle"). I think the existing encoders all use constructors, but that doesn't seem as sustainable if we add more options...

from image.

Yeah. Though, I'd probably suggest calling it "rle" or "compression" or something like that. Even the uncompressed version still counts as "encoding".

Another question is whether it makes more sense to add the new option as a constructor ("with_rle") or as a setter ("set_rle"). I think the existing encoders all use constructors, but that doesn't seem as sustainable if we add more options...

Updated 👍

from image.

I'm trying to read a bit into the code, and just documenting my thoughts.

Looks like tga::Header::from_pixel_data would need another parameter use_rle, and extend the match from:

match color_type {
  ColorType::Rgba8 => (8, 24, ImageType::RawTrueColor),
  // ...
}

to

match (color_type, use_rle) {
  (ColorType::Rgba8, false) => (8, 24, ImageType::RawTrueColor),
  (ColorType::Rgba8, true) => (8, 24, ImageType::RunTrueColor),
  // ... etc
}

Need to check the spec to see if this is the only change required for header.rs.

from image.

Here's my first pass for TGA RLE support:

#2056

from image.