Comments (7)
Hello Henning,
we'd like to understand the context, can you provide the steps to reproduce?
If you also have a suggestion in form of a patch, feel free to share.
from isar.
I guess the way to repro would be to use an "invalid" i.e. empty sources.list
If that happens we indeed could probably detect that early instead of returing something that will just break in a weird way further down the line.
Maybe return None, None, None or simply raise/bbfatal
from isar.
@henning-schild I would highly appreciate that. In my case, the list was not empty. However, I made a typo in the distro name. Thus, nothing was read from the list.
It took me a long time to figure out the root cause. I think throwing an error in this function at isar layer would massively ease debugging.
from isar.
In this case i am afraid the example file would be indeed needed. Because you maybe did not even run into the ["", "", ""]
but instead the parser returned your invalid distro. Which i think we can not do anything about, because the parser should not know all valid values ... would be too hard to maintain.
from isar.
Just have proposed the patch at [PATCH] isar-bootstrap: Fail on invalid apt source list
.
The only inconvenience is that the error during the parsing will be followed by do_bootstrap contents which can be confusing.
from isar.
@amikan Thanks. I will try it and let you know.
from isar.
@amikan It works perfectly. Thanks.
I had to slightly rework you patch as we actually work with this version:
76eac23
from isar.
Related Issues (20)
- Nanopi-neo fails to boot with isar-image-base-debian-bookworm-nanopi-neo.wic HOT 4
- How to increase disk space in /dev/sda1 HOT 2
- Add user with bash HOT 5
- Build isar image installer with empty target image HOT 1
- Adding debian packages to IMAGE
- Run bitbake mc:qemuamd64-focal:isar-image-base, but can't generate wic image HOT 2
- linux-modules/modules.inc doesn't expand AUTOLOAD correctly HOT 2
- Use rootfs when cross-compiling HOT 7
- Enable non-root building - again HOT 2
- Support for buildchroot pooling for parallel builds HOT 2
- sstate-cache support HOT 2
- How to add a customized toolchain HOT 4
- libc dependency issue, HOT 4
- sstate always 0% match. HOT 3
- How to freeze builds? HOT 1
- how to build patched package as multilib (amd64 and i386) in same target HOT 1
- Help: how to use s3 as sstate_cache back end
- gpg-agent failed when using custom apt repository HOT 5
- Add Support for apt_auth.conf for PRODUCT_EXTRA_SOURCES HOT 1
- do_rootfs_quality_check reports warnings when adding >1 new users HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from isar.