Comments (3)
Hey @FIGBERT, thanks for thinking about this! I like the idea but I'm also considering removing IssuerIcons.sketch
from the project altogether. Here's my idea:
Instead of baking rounded corners and borders into the icon images, I'm thinking of having the app do these at runtime when displaying the icons. Furthermore, since the 1x and 2x sizes of the icons are typically downsized versions of the 3x icons, I'm also considering having these generated by a script included in the project. This script could also generate the .imageset
folders.
This would allow the following structure:
Tofu/
├─ IssuerIcons/
│ ├─ Google.png
│ ├─ Github.png
│ ├─ Proton.png
│ ├─ ...
├─ GenerateIssuerIconAssets.sh
GenerateIssuerIconAssets.sh
could then generate the Tofu/Tofu/Assets.xcassets/*.imageset
files.
My hope is that this would make the process of adding icons to the app smoother.
What are your thoughts on this?
from tofu.
I think that generating the icons with a script is really good idea, and having thought about it for a moment shouldn't be too difficult to implement.
Each icon would be given in the 3x size and placed in the IssuerIcons
folder, and GenerateIssuerIconAssets.sh
could use sips
– installed by default on macOS – and jq
to copy and resize the base images into their respective .imageset
folders. I would be very interested in helping out with this. Do you have an opinion as to what language it should be written in (i.e. Bash, Python, even Swift)?
Moving the rounded corners and borders into code rather than the images also seems sensible to me, though I'm more familiar with SwiftUI than UIKit and may need some guidance and some additional Googling.
Regardless, I think it's a really good proposal and would love to help see it through.
from tofu.
I believe this can be closed with the completion of #60.
Update: realized I can close myself lol
from tofu.
Related Issues (20)
- Feature Request: Configuration Option to Exclude OTP Secrets from backup HOT 1
- Add an icon for Cisco, Meraki, Ubiquiti, TikTok, Purism, Palo Alto Networks, login.gov, TaxACT, LocalBTC, Shapeshift.io, Newegg, Bestbuy, Ecobee, Instagram, Coinmama, Linkedin HOT 1
- Project Dead? HOT 2
- Opening the App with biometrics HOT 2
- Opening the App with biometrics HOT 1
- Feature request: support DUO QR codes
- Website Favicon not available
- Project status HOT 1
- I have a question
- Add an icon for Mint Mobile
- Allow access to secret and QR code HOT 1
- Add an icon for AdGuard HOT 1
- Add an icon for Synology DSM
- Add an icon for Kraken (Cryptocurrency exchange)
- Add an icon for Mailbox.org (secure and eco-friendly email inbox from Germany)
- TestFlight link in README does not work HOT 1
- Add an icon for Addy.io
- Feature Request: biometrics / PIN protection HOT 2
- Feature request: delete from search results
- Feature request: let us edit the token detail after added to the list
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tofu.