Change Icon Design Organization about tofu HOT 3 CLOSED

Hey @FIGBERT, thanks for thinking about this! I like the idea but I'm also considering removing IssuerIcons.sketch from the project altogether. Here's my idea:

Instead of baking rounded corners and borders into the icon images, I'm thinking of having the app do these at runtime when displaying the icons. Furthermore, since the 1x and 2x sizes of the icons are typically downsized versions of the 3x icons, I'm also considering having these generated by a script included in the project. This script could also generate the .imageset folders.

This would allow the following structure:

Tofu/
├─ IssuerIcons/
│  ├─ Google.png
│  ├─ Github.png
│  ├─ Proton.png
│  ├─ ...
├─ GenerateIssuerIconAssets.sh

GenerateIssuerIconAssets.sh could then generate the Tofu/Tofu/Assets.xcassets/*.imageset files.

My hope is that this would make the process of adding icons to the app smoother.

What are your thoughts on this?

from tofu.

I think that generating the icons with a script is really good idea, and having thought about it for a moment shouldn't be too difficult to implement.

Each icon would be given in the 3x size and placed in the IssuerIcons folder, and GenerateIssuerIconAssets.sh could use sips – installed by default on macOS – and jq to copy and resize the base images into their respective .imageset folders. I would be very interested in helping out with this. Do you have an opinion as to what language it should be written in (i.e. Bash, Python, even Swift)?

Moving the rounded corners and borders into code rather than the images also seems sensible to me, though I'm more familiar with SwiftUI than UIKit and may need some guidance and some additional Googling.

Regardless, I think it's a really good proposal and would love to help see it through.

from tofu.

I believe this can be closed with the completion of #60.

Update: realized I can close myself lol

from tofu.