Comments (7)
Additional notes:
- Since the serialization of
cobra.Command
is not complete, issues like #3350 can raise on a regular basis. With the simplification this is no longer a problem. - The simplification will break existing plugins. Authors will have to update their plugin code to make it works with the CLI version that has the simplification.
from cli.
I think this could be an interesting topic to discuss on the Community call 👍
from cli.
Not being able to mount commands in places like ignite chain
and ignite scaffold
means there are limits to how plugins can really "extend" CLI from users' point of view. Each org extending the CLI would have to mount under their own top-level name.
ignite acme scaffold foo
instead of ignite scaffold foo
.
And it will make it harder for us to extract functionality into independent plugins as well.
from cli.
Is it possible to enforce flags to be submitted after the command?
❌ ignite scaffold --path ./xxx/yyy wasm
✅ ignite scaffold wasm --path ./xxx/yyy
from cli.
Is it possible to enforce flags to be submitted after the command?
❌ ignite scaffold --path ./xxx/yyy wasm
✅ ignite scaffold wasm --path ./xxx/yyy
Yes that's probably doable, and after we can safely truncate. I just wonder if this isn't going to be complicated if the command also has arguments.
That said, the plugin still needs to redefine the path
flag internally to be able to read it, whereas this flag is defined in the parent comment scaffold
.
from cli.
But arguments will follow the command, right? You can't have ignite scaffold arg1 arg2 foo
, it's always ignite scaffold foo arg1 arg2
.
from cli.
You're right, maybe it's not that complicated.
from cli.
Related Issues (20)
- FIX: Remove "validators" from config.yml When Scaffolding Consumer Chains
- META: Reconsider "Apps" Naming
- UPDATE: Remove Tutorial Content from Official Docs
- UPDATE: Scaffolding Functionality
- META: Revamp CLI Docs HOT 1
- INIT: In-Place Testnet Creation HOT 4
- INIT: Add `--binary` flag to `chain serve` HOT 1
- FIX: ENOSPC Error During `npm run dev` in React Frontend App HOT 3
- Minor UX bug for old versions
- INIT: Flag to Add External Modules
- INIT: `ignite testnet` Command
- FIX: 403 Forbidden error when running `buf export` command HOT 1
- FIX: VCS status error (exit status 128) with `ignite/cli/actions/cli` and `chain build` command HOT 2
- INIT: pass install source to the ignite binary
- FIX: Unable to use SPN due to outdated Ignite version
- FIX: Scaffold params with uint64 crashes Ignite
- init --config doesn't work with multiple config files
- Buf rate limited in CI
- Custom token denomination HOT 1
- Generating ts-client is broken
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.