Message read format about sockjs-go HOT 7 CLOSED

Do you know what was the underlaying protocol for your communication - Websocke/Streaming/Polling? Also could you please make sure that the message from the client is in the format you prefer to be used on server? How do you create json messages on the client?

from sockjs-go.

I found out this is occurring because SockJS runs utils.quote on the input string, which basically JSON encodes the message again. The server should probably json.Unmarshal the message before passing it off in ReadMessage to remove this encoding.

See: https://github.com/sockjs/sockjs-client/blob/master/lib/sockjs.js#L248 and https://github.com/sockjs/sockjs-client/blob/master/lib/utils.js#L250

This is how I'm sending my message:

sock.send(JSON.stringify({
    'op': 'subscribe',
    'channel': 'mychannel'
}));

Which would turn into: ""{"op":"subscribe","channel":"mychannel"}""
Which would be json.Unmarshalled (in Go) to "{"op":"subscribe","channel":"mychannel"}" again

from sockjs-go.

well, you are probably right. sockjs uses a string protocol for messages and encodes each string by JSON.stringify() internally. The inverse operation should be performed on the server on each message.
I probably did a big mistake when defining ReadMessage() to return []byte. It should return "string". And then it would be clear. What you send from the client would be exactly what you get on the server.

I'll need to think about this a little more, this change would cause incompatibilities and I'm not sure how to safely introduce it at this version.

from sockjs-go.

I'm thinking maybe it could either be a config setting, or a separate Read function. This would maintain backwards compatibility.

from sockjs-go.

Feel free to send a patch/pull request if you have any.

from sockjs-go.

Sure, I'll probably create a patch when I can, probably some time this week. I found one other issue with the read format. If the sockjs-client sends 2 messages in rapid succession using xhr (haven't tested all protocols), the payload is sent as a single xhr request which is a JSON array of JSON objects:

["{\"op\":\"subscribe\",\"channel\":\"mychannel\"}","{\"op\":\"subscribe\",\"channel\":\"otherchannel\"}"]

This should probably be decoded into 2 ReadMessage() calls.
To not break old clients, I guess this should stay the same as well unless they use a new Read command or config setting. What do you think?

from sockjs-go.

fixed by #6

from sockjs-go.