Git Product home page Git Product logo

Comments (3)

dmtrek14 avatar dmtrek14 commented on June 2, 2024

The user input is parsed in the order in which a user entered it, so it is true that $initTime is not set yet at this point in the code when an end time is set first. We are checking for init time in this line in order to facilitate the addition of 0-hour tasks, but I will move some code outside of the switch statement to do this check. It seems best to avoid any block in the switch statement relying on any of the variables in other blocks since they could come in any order.

from phpreport.

jaragunde avatar jaragunde commented on June 2, 2024

Good catch, thanks!

from phpreport.

jaragunde avatar jaragunde commented on June 2, 2024

Fixed with:

commit 1dda98ef7c534e0d04bc6f147a0959e1006874b3
Author: Danielle M <[email protected]>
Date:   Wed Feb 8 10:48:13 2023 -0800

    611 midnight task error (#612)
    
    * Move handling for 0-hour tasks outside switch in createTasksService and add same handling in updateTasksService

from phpreport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.