Page stretching on mobile about ifdb HOT 5 CLOSED

1. For historical reasons, we're tracking IFDB bugs in https://github.com/iftechfoundation/ifdb-suggestion-tracker/issues instead of here. (But… maybe we should track them here, instead.)
2. Yeah, mobile support is an after thought on IFDB. I have a PR to improve the game details page, but I got some feedback and never found time to incorporate it, so I still have work to do there. #211
3. I think each of these is a separate bug that would need to be tracked and fixed separately.

from ifdb.

Ah, sorry about that. I think I mistakenly assumed that bugs went here and only suggestions went there. I'll remember that for the future.

Would it help if I submitted separate pull requests for each of these (in the right place this time)? Or should I hold off until you find time to get back to that mobile redesign?

from ifdb.

I'm pretty sure my PR addresses the tags issue, specifically.

If you're excited to work now, I don't want to slow you down.

I think what I should do is dust off the old PR, at least enough to resolve its conflicts. Then I'd say you can feel free to file PRs that both merge cleanly (and appear non-broken) into main and merge cleanly into the mobile-redesign branch.

Meanwhile, I'll see if I can get myself to merge the mobile redesign PR sometime this month, at which point, you're clear to file any mobile-friendliness PR you like.

from ifdb.

I've rebased PR #211; give it a spin.

I've filed iftechfoundation/ifdb-suggestion-tracker#466 on the editgame page
I've filed iftechfoundation/ifdb-suggestion-tracker#467 on the settings page

I actually don't reproduce the My Activity bug, which is to say, I kinda can reproduce it, but not actually on mobile.

IFDB has a legacy-mobile-styles.css stylesheet, designed to hide .rightbar and .tipbox boxes all over the site. The mobile CSS activates only when we user-agent sniff and detect iPhone or Android.

https://github.com/iftechfoundation/ifdb/blob/main/www/util.php#L507
https://github.com/iftechfoundation/ifdb/blob/main/www/legacy-mobile-styles.css

As a result, on actual iPhone/Android, the My Activity page hides "Quick Stats" and "Are You an Author?" and the result looks like this. (But in Firefox/Chrome Dev Tools, if you just resize the window to mobile size, the legacy stylesheet won't activate, and you'll get the broken layout you reported.)

from ifdb.

IFDB has a legacy-mobile-styles.css stylesheet, designed to hide .rightbar and .tipbox boxes all over the site. The mobile CSS activates only when we user-agent sniff and detect iPhone or Android.

https://github.com/iftechfoundation/ifdb/blob/main/www/util.php#L507

Ah, that explains why it's not detecting my Android. I just checked my user agent — it starts with Mozilla/5.0 (Android 14;, which doesn't match the Linux; Android part of that regex.

I'll take a look at your PR next chance I get.

from ifdb.