Git Product home page Git Product logo

Comments (1)

Lucki avatar Lucki commented on May 25, 2024

I looked briefly into it:
I think that happened because I've renamed the gsetting, and it was returning by default an empty path.
The jsonpath then returns directly because of the empty string with a null and then the genericJson is missing the crucial null check. The null is now checked because TypeScript mocked me there.
The schemaId actually will change later on too because they need a dynamic path to support multiple different source settings for the same source type. We can't (and shouldn't?) carry them over easily.
The history is still the same and should still work as before. I have to recheck which elements I've added to the history object.

Edit: I did add a name for the history entry which is used for blocking and saving images. That already was checked against null and is now properly typed for null. The history should be fine. Source settings will be "lost"* however.

*They're still in the dconf but not accessible through the UI.

from randomwallpapergnome3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.