Custom SignInValidation/SignInValidator equivalent to ICustomRequestValidator about identityserver3.wsfederation HOT 13 CLOSED

Possibly. We'll leave this open to discuss.

from identityserver3.wsfederation.

Making the method ValidateAsync in SignInValidator virtual (SignInValidator.cs:40), would allow this functionality using the DI/Registrations feature (while still not making a big fuzz or doing anything that would increase the support burden).

from identityserver3.wsfederation.

Hi,

As it is now SignInValidator is impossible to replace without forking the whole repository, which is a mess. Is there anyway I can elaborate to persuade you to make the change stated above, making ValidateAsync virtual?

Or let SignInValidator implement an ISignInValidator interface?

I would be happy to create a PR if it would be of any help.

(I'm also on gitter in case you want to discuss there)

from identityserver3.wsfederation.

What do you want to achieve?

from identityserver3.wsfederation.

Sorry I missed the first part.

What would you prefer - an extensibility point or make the validator replaceable (with decent base class) ?

from identityserver3.wsfederation.

(Sorry for the silence!)

Well, for me an extensibility point with subject and realm allowing to allow or deny the subject to the realm would be enough, and thus the easiest for me.

But a replaceable validator would do the job too, still being really simple. It really doesn't matter that much for my use case, both would do a great job.

from identityserver3.wsfederation.

ok - will do something. put it on my todo.

from identityserver3.wsfederation.

Wonderful! Just tell me if I can help with anything.

from identityserver3.wsfederation.

Well - if you want open a PR with a custom request validator that runs at the end of the internal validator. Similar to the one in core.

from identityserver3.wsfederation.

Sure thing!

from identityserver3.wsfederation.

Hi, should I PR against master or dev?

from identityserver3.wsfederation.

dev

from identityserver3.wsfederation.

done

from identityserver3.wsfederation.