Unable to get access token if multiple clients are configured where one of them is named "default" about identitymodel.aspnetcore HOT 8 CLOSED

This fails

could you be a bit more specific?

from identitymodel.aspnetcore.

In my case it fails because I do not have a ConfigurationManger on the OpenIdOptions, and so this line throws NullReferenceException:

I guess the question is. What is the desired behavior when there are multiple configured clients and one of them is called "default". Should that really change the behavior of the default client compared to the case when there is only one client?

from identitymodel.aspnetcore.

I am still not 100% clear what the problem is. but the behavior of the default config plumbing allows to have multiple named clients. If you don't pass a name explicitly, it falls bad to a "default" client.

And that's IIRC either the one client (if it is only one) - or the OIDC-based configuration.

Do you think this behavior does not make sense? You are probably aware that you replace the config loading part if you want different behavior.

from identitymodel.aspnetcore.

Ok I will try and clarify.

If I have one defined, named client, no matter the name, then the associated request will always be returned from GetClientCredentialsRequestAsync(). For example:

options.Client.Clients.Add("default", defaultRequest)

or

options.Client.Clients.Add("some-other-name", defaultRequest)

If I have multiple defined, named clients, then the name matters. For example:

options.Client.Clients.Add("client-A", requestA); // This returns the requestA from GetClientCredentialsRequestAsync
options.Client.Clients.Add("client-B", requestB); // This returns the requestB from GetClientCredentialsRequestAsync

but, if one of the clients is named exactly "default", then

options.Client.Clients.Add("default", requestA); // This does NOT return the requestA from GetClientCredentialsRequestAsync
options.Client.Clients.Add("some-other", requestB); // This returns the requestB from GetClientCredentialsRequestAsync

The behavior that makes sense to me would be that if a client is added with the explicit name "default" if more than one client is added, then that request should also be the one that is returned by GetClientCredentialsRequestAsync().

Hope it makes sense :)

from identitymodel.aspnetcore.

And why don't you use the name in your application code when you have more than one client config?

from identitymodel.aspnetcore.

I do. I just happened to explicitly use the name "default". After I renamed it to something else, the code started to work.

from identitymodel.aspnetcore.

Ah I see ;)

from identitymodel.aspnetcore.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.

from identitymodel.aspnetcore.