Error on compiling about velociraptor-stf HOT 9 CLOSED

cmake_config.log
cmake.log

from velociraptor-stf.

Thanks @davidharvey1986 for reporting this.

I see two issues:

• Our src/exceptions.h header doesn't have an include guard, I'll add one.
• Mac's filesystem lookups seem to be case-insensitive, which is causing src/exceptions.cxx's #include "exceptions.h" to include src/exceptions.h (fine), but also making NBodylib/src/Math/NBodyMath.h's #include <Exceptions.h> to include src/exceptions.h instead of NBodylib/src/Math/Exceptions.h (not fine), which causes the error. I think that's easily fixable, but I'll require confirmation from your side to know if that's the case.

from velociraptor-stf.

@davidharvey1986 please try compiling the issue-126 branch, which has an update that fixes both issues above. Beware that you'll need to run git submodule update as the NBodylib submodule has fixes that need to be brought it too.

from velociraptor-stf.

Hi @rtobar. Thanks for responding. This indeed was my conclusion and by specifically stating the exact file path had temporarily fixed the problem on myside. This fix has now solved the issue so thank you....however....

It now doesn't find the HOST_NAME_MAX, which on my limited knowledge is not something that is valid on a MAC (and is not defined in the machine headers) by changing thi tos SC HOST_NAME_MAX works, but I don't know if there is a subtle difference.

Thanks
output.log

from velociraptor-stf.

@davidharvey1986 thanks for reporting that further issue. Using _SC_HOST_NAME_MAX is not exactly correct; however the fully correct way of doing this in all platforms is a bit clunky, so I'll just replace with 100 -- it's a small detail that won't kill anyone.

from velociraptor-stf.

@davidharvey1986 just pushed a further commit to the issue-126 branch, please let me know if that works.

from velociraptor-stf.

This has now compiled. Thank you for your help!

from velociraptor-stf.

Great, I'll merge as soon as I get back to my laptop.

from velociraptor-stf.

Merged to master now, thanks!

from velociraptor-stf.