<Icon /> does not forward the ref about iconify HOT 6 CLOSED

Good catch! Thanks for reporting it.

I'll try to fix that as soon as possible.

from iconify.

Fixed in @iconify/[email protected].

Couldn't figure out how to unit test it, so it comes without unit tests. However, in react-demo package I've added visual test to make sure it works correctly.

Unfortunately couldn't figure out how to pass it from class to child component, so @iconify/react-with-api doesn't support references yet. I'll try to figure it out.

from iconify.

Great, thanks 👍

from iconify.

I'm really struggling with implementing this with API package.

Problem is, component could be rendered instantly or it could render asynchronously, which means render() might return createElement('span', props) or it could return null. Additionally I'm very ill right now, my brain barely functions, which makes it very hard to come up with solutions.

If you have an idea on how to implement it, please help. Without going into Iconify internal functionality, it just needs to be a component could render synchronously and asynchronously (depending if data has loaded) and passes reference to generated svg (content can be anything, I can adapt code for svg). Currently component is using classes, but using hooks will work fine too (I'm using class because I'm not familiar with hooks enough to create stable component).

from iconify.

Fixed in 3.0.0-dev (currently available in react-restructure branch of this repo). Now API package also supports references, which required full rewrite of component.

from iconify.

Awesome, thank you !

from iconify.