Comments (3)
From @JessicaS11's comment on #318 -
It is worth thinking about how the spatial portion might be (potentially) combined with the geospatial.py module as well as utilizing existing libraries to the extent possible to validate and refine inputs. For instance, using Shapely:
import shapely.geometry as geom
bbox = [-55, 68, -48, 71]
b_bbox = [-55, 71, -48, 68]
fmtbox = geom.box(*bbox)
b_fmtbox = geom.box(*b_bbox)
Both fmtbox and b_fmtbox will output (-55.0, 68.0, -48.0, 71.0) as the valid, correctly formatted bounding box. In this case, we could eliminate completely the check + user warning that they entered the coordinates in the wrong order. However, this DOES NOT deal with #151 (which I think is due to #117) and would actually make cross-dateline queries more challenging, so we should keep that in mind before implementing this route (perhaps requiring the user to manually specify via keyword they intend to cross the dateline with their query and then handling the request accordingly?).
from icepyx.
Decided to make this a separate issue so I can look into it after the "first" version of the spatial
class is merged into development (basically the same as the original spatial
function in validate_inputs
with a few structural changes)
from icepyx.
Issue has been resolved with PR #322
from icepyx.
Related Issues (20)
- add some projection handling and checks
- debug tests behind EDL - failing builds for PRs to main HOT 1
- do not run uml updates on PRs into main
- Make Variables an independent class HOT 1
- Unable to call Argo scripts with Quest query object HOT 2
- calls to OpenAltimetry API time out HOT 1
- Intermittent Error on order_granules
- ConnectionRefusedError: [WinError 10061] No connection could be made because the target machine actively refused it HOT 2
- ValueError: cannot reindex or align along dimension 'delta_time' because of conflicting dimension sizes: {1112, 1098} HOT 2
- icepyx required variables
- only add requested beams for required variables
- improve QUEST documentation HOT 2
- figure out where the codecov reports went HOT 2
- become PEP8 compliant
- NSIDC request url generation currently includes duplicate keywords HOT 4
- Allow generating variables wanted from a list of h5 paths HOT 4
- Typo in `pip install -e` instructions on contributing page HOT 5
- remove metadata fix after next version up
- Add Examples Directory HOT 1
- Unable to download 5000005497555 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from icepyx.