Git Product home page Git Product logo

Comments (3)

sjh1024 avatar sjh1024 commented on July 1, 2024

From @JessicaS11's comment on #318 -

It is worth thinking about how the spatial portion might be (potentially) combined with the geospatial.py module as well as utilizing existing libraries to the extent possible to validate and refine inputs. For instance, using Shapely:

import shapely.geometry as geom
bbox = [-55, 68, -48, 71]
b_bbox = [-55, 71, -48, 68]

fmtbox = geom.box(*bbox)
b_fmtbox = geom.box(*b_bbox)

Both fmtbox and b_fmtbox will output (-55.0, 68.0, -48.0, 71.0) as the valid, correctly formatted bounding box. In this case, we could eliminate completely the check + user warning that they entered the coordinates in the wrong order. However, this DOES NOT deal with #151 (which I think is due to #117) and would actually make cross-dateline queries more challenging, so we should keep that in mind before implementing this route (perhaps requiring the user to manually specify via keyword they intend to cross the dateline with their query and then handling the request accordingly?).

from icepyx.

sjh1024 avatar sjh1024 commented on July 1, 2024

Decided to make this a separate issue so I can look into it after the "first" version of the spatial class is merged into development (basically the same as the original spatial function in validate_inputs with a few structural changes)

from icepyx.

sjh1024 avatar sjh1024 commented on July 1, 2024

Issue has been resolved with PR #322

from icepyx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.