Comments (7)
Hi, can u send sample or branch with problems?
https://github.com/parfenovedyard/MokoResSample
While preparing sample noticed that only dark theme causes crash.
On light theme everything works fine, android works fine on dark and light theme.
from moko-resources.
i already said that you should use :composeApp:copyFrameworkResourcesToApp
but you still use :resources:copyFrameworkResourcesToApp
:)
you should use project that produce ios framework. it's composeApp in your case
from moko-resources.
Hi, can u send sample or branch with problems?
from moko-resources.
@parfenovedyard you should apply moko-resources plugin to https://github.com/parfenovedyard/MokoResSample/blob/a46e516150a015a47066186fcce63dd3ec476c01/composeApp/build.gradle.kts#L6
and should not create framework here https://github.com/parfenovedyard/MokoResSample/blob/a46e516150a015a47066186fcce63dd3ec476c01/resources/build.gradle.kts#L22
and also you should change order of build phases in xcode - at first you should compile kotlin framework, then you should copy resources from framework by :composeApp:copyFrameworkResourcesToApp
your current config very not optimal (long build time required), but it's not cause of issue. we will research why dark theme image broken
from moko-resources.
crash on ios with dark images, will be fixed in 0.24.0-beta-2
fix contains in #674
from moko-resources.
@parfenovedyard you should apply moko-resources plugin to https://github.com/parfenovedyard/MokoResSample/blob/a46e516150a015a47066186fcce63dd3ec476c01/composeApp/build.gradle.kts#L6
and should not create framework here https://github.com/parfenovedyard/MokoResSample/blob/a46e516150a015a47066186fcce63dd3ec476c01/resources/build.gradle.kts#L22
and also you should change order of build phases in xcode - at first you should compile kotlin framework, then you should copy resources from framework by
:composeApp:copyFrameworkResourcesToApp
your current config very not optimal (long build time required), but it's not cause of issue. we will research why dark theme image broken
got it, thanks.
Regarding framework, if i change code like this:
without creating framework, just targets.
I got ios build error:
![image](https://private-user-images.githubusercontent.com/78921271/326197729-68957ea2-e8db-4d40-82da-5ff0cf381beb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ0MDczNDcsIm5iZiI6MTcxNDQwNzA0NywicGF0aCI6Ii83ODkyMTI3MS8zMjYxOTc3MjktNjg5NTdlYTItZThkYi00ZDQwLTgyZGEtNWZmMGNmMzgxYmViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDI5VDE2MTA0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZjN2VmN2EzNmNlMGVmNjgyM2QwM2UxMGY4ODBkMGRkNmE1NjUyNGZlM2U5ZDBjMDliYWFkNGMyZjIxOTUzMjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ReS4eKNz3EwGEPC2AOEHEFKI-J6BmhwAHubX7Segqbg)
May add to readme comment about order of build phases in xcode, cz in readme we need add to the end.
from moko-resources.
@ExNDY please add in readme that build phase should be after kotlin framework compilation
May add to readme comment about order of build phases in xcode, cz in readme we need add to the end.
from moko-resources.
Related Issues (20)
- Desktop Image Assets not generating HOT 4
- Seeing crashes on iOS 16/17 when using localized string in compose
- Display image in swift ui HOT 2
- Support Layout Direction along side resources
- update Readme for custom resources sourceSet
- Fix CI checks for 0.24.0 release HOT 4
- Use with redwood HOT 2
- NegativeArraySizeException when syncing with 0.24.0-beta-1 HOT 2
- Symbol "\n" doesn't work in iOs in 0.24.0-beta-1 HOT 2
- Add gradle plugin tests
- The application is crashing on iOS due to painterResource HOT 4
- Generate iOS resources failed due to dev.icerock.moko:parcelize HOT 12
- Color resolved with colorResource on ios is not updated when resource changes HOT 3
- Strange `can't compile assets - 1` error on iOS due to missing simulator HOT 6
- 0.24.0-beta-1 unable to commonize CInterop HOT 5
- Function 'stringResource' can not be called: No function found for symbol HOT 5
- Slow build time HOT 4
- 0.24.0-beta-2 incorrectly translates strings with `&` for Android as just `&` HOT 4
- 0.24.0-beta-2 includes file extension in `files` and `assets` in the resource name HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moko-resources.