Git Product home page Git Product logo

Comments (7)

parfenovedyard avatar parfenovedyard commented on June 19, 2024 1

Hi, can u send sample or branch with problems?

https://github.com/parfenovedyard/MokoResSample

While preparing sample noticed that only dark theme causes crash.
On light theme everything works fine, android works fine on dark and light theme.

from moko-resources.

Alex009 avatar Alex009 commented on June 19, 2024 1

i already said that you should use :composeApp:copyFrameworkResourcesToApp but you still use :resources:copyFrameworkResourcesToApp :)

you should use project that produce ios framework. it's composeApp in your case

from moko-resources.

ExNDY avatar ExNDY commented on June 19, 2024

Hi, can u send sample or branch with problems?

from moko-resources.

Alex009 avatar Alex009 commented on June 19, 2024

@parfenovedyard you should apply moko-resources plugin to https://github.com/parfenovedyard/MokoResSample/blob/a46e516150a015a47066186fcce63dd3ec476c01/composeApp/build.gradle.kts#L6

and should not create framework here https://github.com/parfenovedyard/MokoResSample/blob/a46e516150a015a47066186fcce63dd3ec476c01/resources/build.gradle.kts#L22

and also you should change order of build phases in xcode - at first you should compile kotlin framework, then you should copy resources from framework by :composeApp:copyFrameworkResourcesToApp

your current config very not optimal (long build time required), but it's not cause of issue. we will research why dark theme image broken

from moko-resources.

ExNDY avatar ExNDY commented on June 19, 2024

crash on ios with dark images, will be fixed in 0.24.0-beta-2
fix contains in #674

from moko-resources.

parfenovedyard avatar parfenovedyard commented on June 19, 2024

@parfenovedyard you should apply moko-resources plugin to https://github.com/parfenovedyard/MokoResSample/blob/a46e516150a015a47066186fcce63dd3ec476c01/composeApp/build.gradle.kts#L6

and should not create framework here https://github.com/parfenovedyard/MokoResSample/blob/a46e516150a015a47066186fcce63dd3ec476c01/resources/build.gradle.kts#L22

and also you should change order of build phases in xcode - at first you should compile kotlin framework, then you should copy resources from framework by :composeApp:copyFrameworkResourcesToApp

your current config very not optimal (long build time required), but it's not cause of issue. we will research why dark theme image broken

got it, thanks.

Regarding framework, if i change code like this:
image
without creating framework, just targets.
I got ios build error:

image

May add to readme comment about order of build phases in xcode, cz in readme we need add to the end.
image

from moko-resources.

Alex009 avatar Alex009 commented on June 19, 2024

@ExNDY please add in readme that build phase should be after kotlin framework compilation

May add to readme comment about order of build phases in xcode, cz in readme we need add to the end.

from moko-resources.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.