[BUG] MF_CLASSIC_DETECTION (mfkey32) keys wrong about chameleonmini-rebooted HOT 3 OPEN

Okay, found the real problem. In MifareClassic.c you save DetectionCanary into working memory after UID and then read the whole block 0 from the same memory in CommandGetDetection function of Commands.c. The problem is that the UID is stored in card memory and you try to read it from working memory, where it never existed. Thus, on clear run the GUI becomes 8 bytes of FFs instead of the real UID (and SAK, ATQA, CRC). There are 2 solutions:

1. Move canary into card memory. Then you can read block 0 with a single AppCardMemoryRead function and get both UID and canary
2. Leave locations as they are and replace single AppWorkingMemoryRead function in CommandGetDetection (Commands.c) by AppCardMemoryRead to read first 8 bytes (UID, SAK, ATQA) from card memory and then AppWorkingMemoryRead to read the rest of block 0

from chameleonmini-rebooted.

So, the issue first appeared in the commit 6ec88b4, which was the last one to change MF_DETECTION implementation. Looks like moving it to working memory broke something and it didn't work properly any more. I temporarily fixed it by changing

[CONFIG_MF_CLASSIC_DETECTION]
...
    .CardMemorySize = MFCLASSIC_1K_MEM_SIZE,
    .WorkingMemorySize = DETECTION_MEM_APP_SIZE,
    .ReadOnly = false

to

[CONFIG_MF_CLASSIC_DETECTION]
...
    .CardMemorySize = DETECTION_MEM_APP_SIZE,
    .WorkingMemorySize = MEMORY_NO_MEMORY,
    .ReadOnly = true

in Configuration.c and renaming all AppWorkingMemory commands related to this mode back to AppCardMemory. Just look at the diff of the commit above for better understanding. This is a temporary fix, the real problem is somewhere in working memory

from chameleonmini-rebooted.