Consider moving expectJSONTypes into a plugin about icedfrisby HOT 13 OPEN

I'd love to! My skills aren't super-strong, but I'm certainly eager.

Got a few more ideas for plugins I want to write too, having read that I can extend existing functions.

Also, the docs. Really wanna fix the docs. I'll do that first.

from icedfrisby.

@paulmelnikow xfered 👍

from icedfrisby.

It occurs to me the original scope of this issue slots nicely with the recent removing of the Joi dependency, since Joi would likely be a dependency of this optional plugin.

from icedfrisby.

I'm all for migrating specific functionality to plugins and out of core. 👍

I think that we should expect to see more async plugins that will need an async (Promise) plugin API. I think it might be advantageous to look into what would be required to support this before we push all the features out of core and then be forced to rewrite the plugin interface later.

from icedfrisby.

How would you like to proceed with this? Would you like me to break it out into a separate repo? Or to set up lerna?

from icedfrisby.

I'm game for trying lerna. If it doesn't work, we can just split it out to a separate repo.

Do we want to make an IcedFrisby GitHub org so this isn't under my name going forward? I could make you an owner then.

from icedfrisby.

I've gone ahead and created the organization, and invited you and @cvega.

That reminds me: @Fishbowler, I wonder if you would like to join forces with us. Would be great to have you on board as a maintainer!

from icedfrisby.

Do you want to move the repo over @MarkHerhold?

from icedfrisby.

On the note about expectJSONTypes, I make heavy use of it, but it always feels "different" from other checks.

How could we manage upgrades on existing installs where it's in use? Is it enough to rely on people having solid package.json settings for packages? Maybe we deprecate and issue a warning akin to the multi globalSetup?

from icedfrisby.

@paulmelnikow can you send the invite again? I didn't get anything. 🤔

from icedfrisby.

You should be able to access it here: https://github.com/icedfrisby

from icedfrisby.

How could we manage upgrades on existing installs where it's in use? Is it enough to rely on people having solid package.json settings for packages? Maybe we deprecate and issue a warning akin to the multi globalSetup?

Yea, I think a major semver bump is sufficient, with a mention in the release notes.

from icedfrisby.

Just thinking about making a start on this. One of the migration paths might be to introduce a rename?
expectJSONSchema maybe? I'd like to start getting a few of the plugins into the repo ready for v2

from icedfrisby.