Comments (2)
Right. It would also require an application using Joi to make icedfrisby
a dependency
instead of a devDependency
.
Another option is to make it an optionalDependency
. The Joi support in icedfrisby requires a Joi schema to be passed in, so the user will need to require Joi and create it themselves. This makes optionalDependency
a nice option: the user needs to declare it as a dependency if and only if they are using – and requiring – it. The user also gets a lot of flexibility.
It seems like this is the situation optionalDependency
is designed for!
from icedfrisby.
We could also make Joi an export, but that ties the user to whatever version of Joi IcedFrisy uses.
const Joi = require('icedfrisby').Joi;
from icedfrisby.
Related Issues (20)
- Promoting IcedFrisby HOT 3
- addHeader doesn't always work HOT 12
- Fix documentation of parameters HOT 4
- addHeader should override headers provided by method parameters
- Version 10 of node.js has been released HOT 1
- Headers from different sources aren't treated equally HOT 1
- Builds are failing because of nock/httpbin HOT 4
- Tests are hard to debug HOT 5
- Gitter for IcedFrisby HOT 1
- Implement cookie handling
- Make test runnable using promises HOT 1
- Expectations in after and afterJSON HOT 3
- Allow specifying strings when using path-based expectJSON
- Add conditional `skip()` method
- In 2.2.1 behavior has changed when network connections are disabled
- Making a multipart request breaks inside the request module HOT 2
- Upgrade to Joi 16
- Delay tests are flaky
- The not() function is instance-wide and only works on path match checks HOT 3
- Coveralls won't display information since Organisation change HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from icedfrisby.