Pass di when register module autoloaders about framework HOT 7 CLOSED

It's easy to implement, how about $di = null by default, to keep backward compatibility?
https://github.com/ice/framework/blob/dev/ice/dispatcher.zep#L189
https://github.com/ice/framework/blob/dev/ice/mvc/moduleinterface.zep#L18

from framework.

@mruz it's fine!

from framework.

let loader = this->di->get("loader")

Will get the loader from te di or create a new if not exist, so maybe that way.
Then ModuleInterface::registerAutoloaders(Loader $loader = null), you won't need to update your app if you have just registerAutoloaders() in every module.

from framework.

an amazing feature that allow user to set a higher loading order for the current module when prepend the loading namespaces: $di->loader->addNamespace(__NAMESPACE__ . '\Controllers', __DIR__ . '/controllers/', true);

from framework.

After a sound thought, pass the loader loading the current module to registerAutoloaders($loader) to allow developer control the module loading process.

if people want to access the $di instance, it can be done in registerServices(Di $di)

BTW, add Loader $loader = null to ModuleInterface::registerAutoloaders(Loader $loader = null) doesn't keep backward compatibility. So, ModuleInterface::registerAutoloaders(Loader $loader) is ok

from framework.

@mruz please check my last comment. the follow code will not work as expect, as the loader of the module is not the same as the one in $di->loader. it safe to pass $loader but not this->di.

    // better performance
    public function registerAutoloaders(Di $di)
    {
        $di->loader->addNamespace(__NAMESPACE__ . '\Controllers', __DIR__ . '/controllers/');
    }

from framework.

I didn't see your comment.

from framework.