Rotate fails with applicatoin shutdown about rotating-file-stream HOT 8 CLOSED

Your filename generator function does not accept the time parameter.
Change this and apply same change I already suggested...

from rotating-file-stream.

Hi,

the first thing I see that could be cause of unexpected behaviour is:

if (!time) time = new Date();

in your filename generator.

This will cause your program to create the log file with a name which is function of the day when your program was launched.

I strongly suggest to change it in:

if (!time)
  return 'access.log';

Anyway I can't say if that is the root cause of the reported problem.

The error is clear: there is some write attempt after a close call.
RotatingFileStream will close by itself after an error... you can try to add an error event listener to check if that is the case:

accessLogStream.on('error', console.log.bind(console));

Please let me know about your progress with this issue.

Thank you,
iCC

from rotating-file-stream.

Hi man!

Any news about your issue?

from rotating-file-stream.

Hey @iccicci, thanks for your hints... I guess you're right regarding time. Works now.

from rotating-file-stream.

let logStream = rfs((index) => {
  return `${moment().format('YYYYMMDD')}.log`
}, {
  interval: '1d',
  path: logDir
})

i meet the same error when i wana use the date to name my logs file.

from rotating-file-stream.

@iccicci i have already read your suggestions, I‘ll update the code in the server in the midnight and check the log files later. thanks for your reply.

from rotating-file-stream.

Hi @unliar ,

any news about your issue?

from rotating-file-stream.

@iccicci everything goes well. many thanks for your help.

from rotating-file-stream.