Comments (3)
dweindl
commented on July 23, 2024
I think generally we want to have the assertions also in the optimized code. I don't think we have any performance-critical ones.
Just replace asserts by (the slightly longer) if not expression: raise AssertionError.
Inside tests, don't use assert but the checking/assertion functions of the test framework. EDIT: Okay, pytest wants assert...
from pypesto.
dweindl
commented on July 23, 2024
Disabled the bandit check. Let's keep assert usage in non-testing code to minimum. They should be replaced by raise and appropriate errors.
from pypesto.
yannikschaelte
commented on July 23, 2024
yes agree, you can enable bandit again if you think that is better. I will use Exceptions instead of assert in real code, and in the tests use the unittest environment, giving assertEqual etc. that is fine for me.
from pypesto.
Related Issues (20)
- pypesto v0.4.2 not on pypi / fix pypi deployment HOT 2
- Multistart optimization with parameter constraints HOT 12
- Visualize: add description of scale in parameter plots
- Update jax objective to pure callback
- Petab import in try/except clause that fails when amici is not available HOT 3
- SacessOptimizer: Allow specifying multiprocessing start method
- `Ensemble.from_optimization_{history,endpoints}` assumes that `OptimizerResult.id` is always convertible to `int`
- Relative: implement log-normal distribution
- ImportError: cannot import name 'gaussian' from 'scipy.signal' HOT 5
- What's the purpose of `Ensemble.predictions`? HOT 1
- General Discussion regarding Ensemble HOT 7
- Handling of simulation failures in AmiciPredictor
- Frequent timeouts of RTD builds HOT 3
- Waterfall plot error: `order_by_id` and `start_indices` do not work together
- Optimization with conditions specific for observables fails HOT 4
- Frequent timeouts for `mac (3.11)` workflow runs HOT 3
- Check pypesto/sample/geweke_test.py calculate_zscore/spectrum0/spectrum
- Frequent readthedocs timeout HOT 1
- `pyjulia` is no longer maintained
- Roadrunner petab test case 0018 fails on Mac HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pypesto.