Not compatible with flutter_map v4.0.0 about flutter_map_dragmarker HOT 10 CLOSED

I've updated this in Git. Can you give it a go, and check the dragging works ok, as a few bits changed in flutter_map v4 affecting that.

Note the removal of //absorbPanEventsOnScrollables: false, from flutter_maps MapOptions as no long available.

from flutter_map_dragmarker.

@ibrierley I'll do a pull request with some additional changes.

from flutter_map_dragmarker.

Thanks, there's a few other publish warnings (prints and consts) I was just looking at (the lib/main.dart can probably go), but one I'm confused by is...

info - lib/dragmarker.dart:9:9 - Constructors for public widgets should have a named 'key' parameter. Try adding a named parameter to the constructor. - use_key_in_widget_constructors

However, the constructor does take a key value const DragMarkers({Key? key, this.markers = const []});

Any thoughts ?

from flutter_map_dragmarker.

Will be fixed in josxha@4492d95.

const DragMarkers({Key? key, this.markers = const []})

does not actually make use of the key. I wasn't aware of this for a long time, too.

The old implementation would've needed to pass the key to the super constructor with

const DragMarkers({Key? key, this.markers = const []}) : super(key: key);

But there is an awesome new feature in dart where you can just use it as follows:

const DragMarkers({super.key, this.markers = const []});

(Btw that's why I raised the minimum dart sdk version to match flutter_map in flutter_map_line_editor and now in this package 😁)

from flutter_map_dragmarker.

Aha ok, super, thanks for the explanation.

from flutter_map_dragmarker.

Can you please update us when the new version is published?

from flutter_map_dragmarker.

There's a version on Git in the meantime that works with it.

from flutter_map_dragmarker.

(sorry, I wouldn't nec recommend doing that as there may be some more changes, but just if you need it in the interim)

from flutter_map_dragmarker.

Please publish new version in pub.dev

from flutter_map_dragmarker.

Should be done

from flutter_map_dragmarker.