bug: typing issue with `filter` method on the table column about ibis HOT 2 CLOSED

Hi - thanks for opening this. Two things:

• Our type annotations aren't great. Ibis code is pretty dynamic, generally you can trust the output of the method/function/whatever to be properly typed, but the types of arguments are likely stricter than things that are actually supported. In this case here filter is annotated to take a BooleanValue (which will accept a BooleanScalar or BooleanColumn), but it also will work with a standard bool (ibis will automatically coerce to a BooleanScalar). Going through the APIs to improve the accuracy of the type annotations and add tests to ensure they're accurate is a large project and not one we're prioritizing at the moment. Right now I recommend either submitting PRs to fix annotations for bugs that you run into, or (better, more feasible suggestion) just turn off typing for ibis.

• In your specific case this is also a case of user error. The .equals method on an expression checks for expression-level equality (whether the left and right side are identical expressions). t.filter(t.a == 0) is what you want here.

from ibis.

Thanks for the feedback - it all makes sense. I'm happy to close this as this is not really a bug, and I see if I can come up with a PR that addresses the specific issue here.

from ibis.