Comments (6)
I think we're doing something wrong:
[ins] In [25]: exp = sg.parse_one("CREATE TEMPORARY TABLE temptest (name VARCHAR);",
...: dialect="duckdb")
[ins] In [26]: exp
Out[26]:
Create(
this=Schema(
this=Table(
this=Identifier(this=temptest, quoted=False)),
expressions=[
ColumnDef(
this=Identifier(this=name, quoted=False),
kind=DataType(this=Type.VARCHAR, nested=False))]),
kind=TABLE,
properties=Properties(
expressions=[
TemporaryProperty()]))
[ins] In [27]: exp.sql(dialect="mssql")
Out[27]: 'CREATE TABLE #temptest (name VARCHAR)'
from ibis.
FYI the temp table fix has been deployed with 23.13.0.
from ibis.
Hmm, yeah, something funky is definitely happening here. The create table SQL we're generating (this is for the starwars example): is
'CREATE TABLE #[ibis_mssql_table_sf22odm3xvcjxhkiuk5pk6o4py] ([name] VARCHAR(max), [height] BIGINT, [mass] FLOAT, [hair_color] VARCHAR(max), [skin_color] VARCHAR(max), [eye_color] VARCHAR(max), [birth_year] FLOAT, [sex] VARCHAR(max), [gender] VARCHAR(max), [homeworld] VARCHAR(max), [species] VARCHAR(max), [films] VARCHAR(max), [vehicles] VARCHAR(max), [starships] VARCHAR(max))'
Definitely don't need or want the #[]
around the table name
from ibis.
hmm, wait, I guess that's the mssql syntax for temporary tables? digging in a bit more
from ibis.
I think this is a sqlglot bug, although we may be constructing the expression incorrectly.
[nav] In [14]: query = """CREATE TABLE #crunch_no_brackets ([name] VARCHAR(max))"""
[ins] In [15]: with con.raw_sql(query) as c:
...: pass
[ins] In [16]: query = """CREATE TABLE [brackets_no_crunch] ([name] VARCHAR(max))"""
[ins] In [17]: with con.raw_sql(query) as c:
...: pass
[ins] In [18]: query = """CREATE TABLE #[brackets_with_crunch] ([name] VARCHAR(max))"""
[ins] In [19]: with con.raw_sql(query) as c:
...: pass
---------------------------------------------------------------------------
ProgrammingError Traceback (most recent call last)
Cell In[19], line 1
----> 1 with con.raw_sql(query) as c:
2 pass
File ~/github.com/ibis-project/ibis/ibis/backends/mssql/__init__.py:279, in Backend.raw_sql(self, query, **kwargs)
276 cursor = con.cursor()
278 try:
--> 279 cursor.execute(query, **kwargs)
280 except Exception:
281 con.rollback()
ProgrammingError: ('42000', "[42000] [FreeTDS][SQL Server]Incorrect syntax near 'brackets_with_crunch'. (102) (SQLExecDirectW)")
from ibis.
Ok, I think that there are some edge-cases that we are definitely not handling correctly.
That said, there is also a sqlglot bug:
[ins] In [1]: import sqlglot as sg
[ins] In [2]: exp = sg.parse_one(
...: "CREATE TEMPORARY TABLE 'temptest' (name VARCHAR);", dialect="duckd
...: b"
...: )
[ins] In [3]: exp
Out[3]:
Create(
this=Schema(
this=Table(
this=Identifier(this=temptest, quoted=True)),
expressions=[
ColumnDef(
this=Identifier(this=name, quoted=False),
kind=DataType(this=Type.VARCHAR, nested=False))]),
kind=TABLE,
properties=Properties(
expressions=[
TemporaryProperty()]))
[ins] In [4]: exp.sql(dialect="tsql")
Out[4]: 'CREATE TABLE #[temptest] (name VARCHAR)'
That last should be CREATE TABLE [#temptest] (name VARCHAR)
from ibis.
Related Issues (20)
- feat(api): Add `order_by` parameter to the `collect()` method HOT 3
- Postgres error: DateDelta HOT 2
- feat(pyspark): support udaf
- bug HOT 1
- bug: Oracle Table alias HOT 8
- bug: Installation issue: mamba on Windows 10 HOT 6
- feat: Table.to_records()
- feat: `backend.db_params`
- `collect` does not respect order HOT 2
- bug Error when connecting to Trino after upgrading to 9.0.0
- bug: table formatting characters don't render monospace with some fonts HOT 5
- bug: `read_parquet` and similar methods silently overwrite tables HOT 2
- bug: names_sort argument in table.pivot_wider has no effect HOT 1
- feat: add a method for table existence check HOT 5
- bug: `create_table(temp=True)` timing out due to slow table existence check HOT 2
- add support for TIMESTAMPTZ HOT 4
- feat: add a table_exists(table_name) api HOT 1
- bug: `to_sql` always shows DuckDB SQL for a memtable even if there's a default backend set HOT 1
- Polars backend can read only 1 csv HOT 1
- docs: add ops docstrings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ibis.