When I have a multi-value attribute like <div class="highlight highlight-source-js

To reproduce: Go to <a href="https://www.w3schools.com/tags/tryit.asp?filename=tryhtml

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

I'm sorry for your trouble <a class="user-mention notranslate" data-hovercard-type="us

No need for [] when skipping index for an array about form-urlencoded HOT 6 CLOSED

iambumblehead commented on May 23, 2024

No need for [] when skipping index for an array

from form-urlencoded.

Comments (6)

binarykitchen commented on May 23, 2024

To reproduce: Go to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_form_checkbox

then use this HTML

<!DOCTYPE html>
<html>
<body>
<form action="/action_page.php" method="get">
  <input type="text" name="test" value="Bike">
  <input type="text" name="test" value="Bike2">
  <input type="text" name="test" value="Bike3">
  <input type="text" name="test" value="Bike4">
  <input type="submit" value="Submit">
</form>
</body>
</html>

that will yield test=Bike&test=Bike2&test=Bike3&test=Bike4

from form-urlencoded.

iambumblehead commented on May 23, 2024

@binarykitchen I'm not sure when I will be available to look into this. Is it an important issue for you?

Do you think the change would be safe for packages using this package?

from form-urlencoded.

binarykitchen commented on May 23, 2024

@iambumblehead i think this will become a breaking change. recommend a new version with that behaviour and to add new options for those who want the old behaviour.

yep, important here. i could do a PR today to speeden things up. would you accept that?

from form-urlencoded.

iambumblehead commented on May 23, 2024

@binarykitchen that's very kind of you. Yes, a PR with a test would be accepted.

from form-urlencoded.

binarykitchen commented on May 23, 2024

@iambumblehead lol, forget it. discovered a hidden parameter skipBracket in your code. works now for me. maybe you should document it one day ...

from form-urlencoded.

iambumblehead commented on May 23, 2024

I'm sorry for your trouble @binarykitchen. yes it should be documented.

from form-urlencoded.

Recommend Projects