Git Product home page Git Product logo

Comments (1)

a-0-dev avatar a-0-dev commented on May 28, 2024

I found the issue and I'm close to submitting a PR for this. The wording in I2P documentation is ambiguous: "destination" can both be the public part of a node's key material, as described in the host name lookup documentation:

The $destination is the base 64 of the Destination, which is 516 or more base 64 characters (387 or more bytes in binary), depending on signature type.

...as well as the private part of a node's key material, as described in the Session Creation Response chapter of the documentation:

SESSION STATUS RESULT=OK DESTINATION=$privkey
The $privkey is the base 64 of the concatenation of the Destination followed by the Private Key followed by the Signing Private Key, optionally followed by the Offline Signature, which is 663 or more bytes in binary and 884 or more bytes in base 64, depending on signature type. The binary format is specified in Private Key File.

So, before I submit a solution allowing a user of i2p-rs to extract the private key of a node from a Session: Should there be a name destinction (as in, e.g., always name the "private destination" private key or privkey while using "destanation" for the public part? I think that makes most sense, since a "destination" is usually something you send something to (hence, only have the public part of the key material), while the private part should be explicitly named private so i2p-rs users don't "accidentally" use it in an unsafe way.

Any thoughts on this?

from i2p-rs.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.