Git Product home page Git Product logo

Comments (8)

jamuhl avatar jamuhl commented on May 17, 2024

Working on removing dependency on JQuery right now. Will have a look to check for window existing before calling on it, too.

Should be ready by end of week (i hope).

from i18next.

jamuhl avatar jamuhl commented on May 17, 2024

Should work in version 1.5.5. If still having some issues feel free to reopen this one.

from i18next.

mou avatar mou commented on May 17, 2024

Actually you are using invalid availability test
if (window) {
}
raises ReferenceError because window is undefined and "if" is trying to cast window to boolean. There should be another check which dosnt raise ReferenceError

from i18next.

jamuhl avatar jamuhl commented on May 17, 2024

Not sure what you mean. If window doesn't exits it's undefined - if (undefined) -> won't execute.

Is this different in rhino or am I missing something?

from i18next.

mou avatar mou commented on May 17, 2024

No matter is it Rhino or Browser. If you try to perform

if (nonexistentVariable) {
}

in browser console you receive ReferenceError.

from i18next.

mou avatar mou commented on May 17, 2024

As i found there are safe check using typeof operator.
Example of use – apres/Sinon.JS@1430491

from i18next.

jamuhl avatar jamuhl commented on May 17, 2024

will change this for next release...not sure when it will come...might be next week.

As i don't test with rhino - feel free to fork, change and do a pull-request - so it runs on your machine, else i will try my best to find all possible traps.

from i18next.

mou avatar mou commented on May 17, 2024

Made a pull request #34
So i close this issue

from i18next.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.