Git Product home page Git Product logo

Comments (8)

bitkeeper avatar bitkeeper commented on May 22, 2024 1

In that case I made a buzz about nothing 😪. @karellm already added comment-line switch --ignoreVariables with version 0.10. Then it provides a warning instead of an error.

from i18next-parser.

bitkeeper avatar bitkeeper commented on May 22, 2024

I see that is introduced in PR #40 by @laszlopandy .

We use a mix of i18n.t("mykey") and i18n.t(myvar)
i18n.t support both, using the variable is typically for translating dynamic texts. Which is very common in general programs.

We use the scanner only to extract the string version and are completely fine with the fact that the scanner ignores the one with the variable. I can imagine that you want to have a commandline argument to enable warning about it, but don't allowing this kind of use can not be the intention I suppose.

from i18next-parser.

laszlopandy avatar laszlopandy commented on May 22, 2024

Can you explain to me how you translate dynamic texts? I mean, how will the translated string be available for the I18n.t() to return if the scanner cannot identify that this string is one to be translated?

from i18next-parser.

bitkeeper avatar bitkeeper commented on May 22, 2024

Typically the dynamic strings aren't part of the frontend, but the backend.
In our case the dynamic returned strings are in the form of a i18next key.

We provide a separate namespace file for those items (no conflict with the namespaces generated by the scanner ). Those namespace files can be either generated from master data or manually put together.

The separate namespace files are merged and upload to https://localise.biz/, after translation we download a file per language.

from i18next-parser.

laszlopandy avatar laszlopandy commented on May 22, 2024

If you anyway have the strings in a different namespace, why don't you use a different function to get the translation for them? I18n.t for literals and I18n.v for variables for example. Then the scanner would still give you a warning if you accidentally did this:

var msg = "Really long translatable string which we put into a variable so the next line doesn't wrap";
initializeWidgets([Buttons.OK, Buttons.CANCEL], I18n.t(msg), callback);

from i18next-parser.

bitkeeper avatar bitkeeper commented on May 22, 2024

Your suggestion make sense. Only now you force existing code to be changed, to support the detection.

The scanner behaves different after the patch then before, rather I would prefer that in such cases that new behavior can be enable or disabled by command-line.

from i18next-parser.

laszlopandy avatar laszlopandy commented on May 22, 2024

I'm ok with having a command line switch as well. That is a reasonable solution.

from i18next-parser.

jamuhl avatar jamuhl commented on May 22, 2024

@bitkeeper You shoudn't use https://localise.biz/ but our own service http://locize.com -> this way you support the future of i18next ;)

from i18next-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.