Memoize lookup in parse is producing false positives about i18next-icu HOT 3 CLOSED

Yes, I have configured keySeparator: false in i18next.init, I'll open a PR to do the replace.

from i18next-icu.

I suppose the memoization could perhaps work differently as well, avoiding nesting and instead using the key as a concrete property (i.e changing the way the utils work), but as I lack the context I might be missing something on why the memoize memory needs to be a deep object. Performance-wise it might actually be better to have a flat object.

It also raises a question about keys that contain .format. in them, as those would potentially have a conflict with the memoized IntlMessageFormat object.

from i18next-icu.

how can you have 2 keys foo.bar and foo.bar.baz existing side by side? Did you set keySeparator to false on init? If so yes...we need to fix this by changing that to replace the . in keys (as that is the fallback on that set/get) https://github.com/i18next/i18next-icu/blob/master/src/index.js#L52

fc = utils.getPath(this.mem, ${lng}.${ns}.${key.replace('.', '###')});

would you like to provide a PR?

from i18next-icu.