Git Product home page Git Product logo

Comments (2)

robertknight avatar robertknight commented on June 25, 2024

OpenStax pages are also affected in a limited way by the font size issue captured in #4615.

from client.

robertknight avatar robertknight commented on June 25, 2024

We protect most of the UI from interference by the host page by using Shadow DOM, inside <hypothesis-*> host elements. The host elements are protected from most unwanted rules by having a custom element name, so as not to be affected by generic rules for <div> etc. However universal selector rules (* { ... }) can still affect them, as well as some combinators involving universal selectors (body > * etc.). The simplest solution in this instance would be to add a higher specificity selector that resets just overflow on the <hypothesis-*> host elements, and leaves a placeholder to reset any other rules that we find to be problematic in future. We could also do something more generic and add eg. hypothesis-adder, hypothesis-sidebar, hypothesis-notebook { all: revert }.

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.