sovrin_sign and sovrin_verify_signature should support arbitrary byte array about indy-sdk HOT 5 CLOSED

Personally, I agree with this issue. Looks like the current implementation of sovrin_sign and sovrin_verify_signature calls that only allows signing off messages to pool with very specific digest creation is some result of our internal misunderstanding. Also, it doesn't correspond to this calls docs.

@ashcherbakov

Can you re-check this?

from indy-sdk.

From another point of view

The main use case of sovrin_sign call is signing of transaction messages that were created with sovrin_build_*_request calls. It allows splitting of communication logic from private keys management for better security of real applications.

Ledger communication requires the creation of complex custom digests and injection of the signature field to original json messages. So we can't just easily make this calls generic without loosing of ability to sign ledger messages. Maybe we can add another call that is intended for the signing of generic messages.

@ashcherbakov
@dhh1128

What to you think about this?

from indy-sdk.

An earlier version of the API had a sovrin_sign() function that could sign arbitrary messages. I'm not sure why we removed it, but I've always considered it a good idea.

from indy-sdk.

Closing this Github issue and creating JIRA issue instead: https://jira.hyperledger.org/browse/INDY-361

from indy-sdk.

Moved again; this time to https://jira.hyperledger.org/browse/IS-158

from indy-sdk.