Comments (3)
nguyer
commented on August 16, 2024
This is a good suggestion. The reason it works the way it does is that any error returned from a Cobra RunE() will print usage by default. So we'll need to handle errors at the top level differently.
from firefly-cli.
apoorvam1
commented on August 16, 2024
I can pickup this one.
from firefly-cli.
apoorvam1
commented on August 16, 2024
Here's my finding: We need to suppress usage info for internal errors with cmd.SilenceUsage = true and not call the cobra.CheckErr() function here explicitly https://github.com/hyperledger/firefly-cli/blob/main/cmd/root.go#L85 as it results in printing the error message twice.
When there is an error, cobra library prints the error message by default.
from firefly-cli.
Related Issues (20)
- Besu networks only: 'ff upgrade' results in unusable stack. The ff_core-nodes fail to start - Log message: FF10412 - Bad network version: %!!(MISSING)s(<nil>)
- ff info command only works with --verbose flag HOT 1
- Recipients don't appear on sandbox homescreen, for sending private messages HOT 6
- Documentation for "--release" option to init is incorrect HOT 1
- 500 - failed to invoke backing implementation of 'InstallChaincode' HOT 2
- Builds failing due to goreleaser deprecation/removal of `replacements`
- Add --path to "ff" commands HOT 8
- Fabconnect exited(1) HOT 11
- Redundant command to list stack on local machine
- Add support for Fabric v2.5 LTS release
- info command should output stack information
- runtime shell completion for stack names
- looking for help for setup evm connect only connect to hyperledger besu HOT 1
- Failed to find installed chaincode HOT 2
- Failing Unit Tests
- Enhance CLI arguments
- Environment deletion fails with FF CLI built from `main` HOT 6
- More control over docker-compose content HOT 5
- Error: failed to find installed chaincode HOT 1
- ff init command does not work HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firefly-cli.