Comments (4)
In case you didn't already plan it this way, I think it should be configurable, maybe as setters on the Adjudicator
and Depositor
classes. Or as a global variable of the backend/ethereum/channel
package?
And does it make sense to use different depths for different events? Waiting for a Deposited
event is more similar to the situation of exchanges. On the other hand, if a malicious Registered
event is seen, it may make sense to react quicker, that is, to use a lower finality depth.
from go-perun.
In case you didn't already plan it this way, I think it should be configurable, maybe as setters on the
Adjudicator
andDepositor
classes. Or as a global variable of thebackend/ethereum/channel
package?
I currently use a package variable for all calls, but this is only the first draft for testing.
Deciding how configurable we want/need it is also part of this issue discussion.
I will bring it up in the daily tomorrow, maybe we can make a meeting and sketch it out.
from go-perun.
It should be configurable at instantiation. We can also have a separate meeting to talk through it in detail. Let me know.
from go-perun.
We made it configurable in #245
from go-perun.
Related Issues (20)
- Settling after finalization through ForceUpdate HOT 2
- Separate Ethereum backend HOT 1
- Settle channel when funding fails HOT 1
- Separate type for channel.AppID
- Failing client tests: Invalid version
- Deadlock when accessing channel state
- Replace `context.TODO()` with appropriate context HOT 1
- Add Adjudicator Getter for Multi-Adjudicator
- Create test case for dispute with app
- Cannot close multi-ledger Channel
- Unclear specification of adjudication methods HOT 1
- Implement timeouts for mock backend subscription
- Create a MAINTAINERS.md file HOT 1
- Risk of conflicting channel states
- Add authentication to wire commmunication (handshake) HOT 2
- Multi-backend: Specify intended chain ID(s) in channel Params/proposal, clarify architecture. HOT 3
- Improve race detection in endpoint registry
- More generic `ChannelID` calculation
- Include Cardano backend in README
- Failing unit tests HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-perun.