Git Product home page Git Product logo

Comments (4)

sebastianst avatar sebastianst commented on July 29, 2024

In case you didn't already plan it this way, I think it should be configurable, maybe as setters on the Adjudicator and Depositor classes. Or as a global variable of the backend/ethereum/channel package?

And does it make sense to use different depths for different events? Waiting for a Deposited event is more similar to the situation of exchanges. On the other hand, if a malicious Registered event is seen, it may make sense to react quicker, that is, to use a lower finality depth.

from go-perun.

ggwpez avatar ggwpez commented on July 29, 2024

In case you didn't already plan it this way, I think it should be configurable, maybe as setters on the Adjudicator and Depositor classes. Or as a global variable of the backend/ethereum/channel package?

I currently use a package variable for all calls, but this is only the first draft for testing.
Deciding how configurable we want/need it is also part of this issue discussion.
I will bring it up in the daily tomorrow, maybe we can make a meeting and sketch it out.

from go-perun.

matthiasgeihs avatar matthiasgeihs commented on July 29, 2024

It should be configurable at instantiation. We can also have a separate meeting to talk through it in detail. Let me know.

from go-perun.

matthiasgeihs avatar matthiasgeihs commented on July 29, 2024

We made it configurable in #245

from go-perun.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.