Comments (1)
It's easier for me to comment into the code if you create a pull request.
This is a simple function, so the tests are simple: reject everything that is not mode()
/typeof()
/and class()
character and that has length() < 1
- then test that a few keys that are present in the table return TRUE
, and some that are not present return FALSE
.
Should NA
in the input return NA
or FALSE
? By analogy to is.finite(c(1:3, NA, 4L))
I vote it should return FALSE
, not NA
.
A character string that is not in the table is not "invalid", but input values like TRUE
, or 3.142
, or a data frame would be invalid. That done, I can't imagine "corrupt" input, so unless you can think of some, we can skip that. "Corrupt" would mean that it could violate some of the internal assumptions of the function. But there really are none.
Testing the script that parses the HGNC table is another matter, but we can't really do that because we are not running the script through testthat()
. So we'll just have to read it carefully.
Reviewed - write the tests.
from rete.
Related Issues (20)
- importPDB.R pseudocode HOT 1
- Pushed DIFFUSE.R and testDIFFUSE.R to whitleyo/rete repository HOT 7
- importPDB.R pseudocode HOT 1
- Sel3D test case design ready for review HOT 7
- importMapCoord.R ready for review HOT 1
- symmetrical edges HOT 2
- testImportMapCoord.R is ready to be reviewed
- Requested review of psuedocode for importConservation HOT 1
- psuedocode for IMPORT-N.PSIMITAB HOT 1
- mapCoord.R, testMapCoord.R ready for review HOT 4
- ready for review - anuvar HOT 2
- SEL3D ready for review HOT 3
- GOannotation task page for review HOT 1
- Pseudocode and test cases for importConservation. HOT 1
- QA task complete. Ready for review. HOT 2
- importPDB.R HOT 2
- SEL3D comments addressed HOT 1
- Goannotation model HOT 1
- importPDB.R HOT 5
- exploreBeta HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rete.