Git Product home page Git Product logo

Comments (3)

alexwlchan avatar alexwlchan commented on August 15, 2024

Iā€™m using the following diff in my fork, and that seems to have resolved my problems for now:

                 if output.status.success() {		                 if output.status.success() {
                     let output_string = String::from_utf8(output.stdout).unwrap().trim().to_owned();		                     let output_string = String::from_utf8(output.stdout).unwrap().trim().to_owned();
                     // padded with extra 'ffffff' before each octet?		
+                    Ok(output_string)
-                    //println!("{:?}", output_string);
-                    match output_string.from_hex() {		
-                        Ok(bytes) => {		
-                            // filter out extra 255?		
-                            let bytes: Vec<_> = bytes.into_iter().filter(|&b| b != 255).collect();		
-                            Ok(String::from_utf8(bytes).expect("error converting hex to utf8"))		
-                        },		
-                        _ => Ok(output_string),		
-                    }		
                 } else {
                     Err(KeyringError::MacOsKeychainError)
                 }		

from keyring-rs.

hwchen avatar hwchen commented on August 15, 2024

Hi,

Thanks for the report! I'm in the process of procuring a mac to help finish up development on this library.

I should be able to push a fix to crates.io by the end of the week, hope you can make do for now. I need to go back and verify the behavior of http://stackoverflow.com/questions/22370552/keychain-services-secure-notes and see if I just made a dumb mistake in the original implementation.

After that, I'm going to finish up my plans for this lib:

from keyring-rs.

hwchen avatar hwchen commented on August 15, 2024

Closed by #6. Now handles utf8 passwords (including "special chars) on osx correctly. Version is bumped to 0.2

from keyring-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.