Git Product home page Git Product logo

Comments (8)

Kassiematis avatar Kassiematis commented on July 21, 2024 1

This should be removed from the script on line 588.

--o:storage.filesystem[@allow]=true

only this test will not work anymore.

https://:9980/loleaflet//loleaflet.html?file_path=file:///opt/online/test/data/hello-world.odt

from officeonlin-install.sh.

aalaesar avatar aalaesar commented on July 21, 2024

Hi.
Thank you for reporting this very important issue.
At this point I'm not sure if this vulnerability is implied by the libreoffice online design or
if this this a test feature that should be deactivated either in config or in the build.
This requires more investigations.
Like testing this vulnerability from an external network. And maybe a comparative test with the official collabora docker image.

from officeonlin-install.sh.

aalaesar avatar aalaesar commented on July 21, 2024

@Kassiematis
it's config then, nice !
πŸ‘

from officeonlin-install.sh.

yahesh avatar yahesh commented on July 21, 2024

Seems to work for us. :)

from officeonlin-install.sh.

Kassiematis avatar Kassiematis commented on July 21, 2024

Should we change the script? Testing availability can still be done with this link.
https://admin:password@localhost:9980/loleaflet/dist/admin/admin.html

In /opt/online/loolwsd.xml it can still be activated by changing

<storage desc="Backend storage"> <filesystem allow="false" />

to true

For debug/testing purposes only.

from officeonlin-install.sh.

aalaesar avatar aalaesar commented on July 21, 2024

definitively yes but we must find how to remove the prompt showing the test URI or many won't understand why the test instructions are not working.
Https://ip:9980/hosting/discovery is also a good way to test the service availability.

from officeonlin-install.sh.

Kassiematis avatar Kassiematis commented on July 21, 2024

Prompt can be removed by removing --enable-debug at line 316

lool_configure_opts='--enable-debug'

https://admin:password@localhost:9980/loleaflet/dist/admin/admin.html still works

from officeonlin-install.sh.

Kassiematis avatar Kassiematis commented on July 21, 2024

Pull requests created,

#97
#98

from officeonlin-install.sh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.