Comments (43)
Just want to confirm, my test from 5 days ago was successful. Great work guys. :)
from officeonlin-install.sh.
I also have a lot of problems in Libreoffice Online. Especially with column and row resizing. Spreadsheets with filters, formulas etc. can also be tricky.
I think that the demo version is different from the open source one. Not al code is supplied with the open source version.
from officeonlin-install.sh.
Yes you are right, the demo version seems to be based on collabora which seems not to be opensource. Well, I thought only I have those issues, thank you.
from officeonlin-install.sh.
The Collabora demo seems to get their source for Libreoffice from https://github.com/LibreOffice/core.git and not http://download.documentfoundation.org/libreoffice. Could that be the difference?
from officeonlin-install.sh.
that's an interesting point
the fact that latest commit in LoOnline master branch could be based on LibreOffice master branch instead of a release.
It would be interesting to check how Loolwsd is more functional when compiled from a branch named after a LO release instead of master, like libreoffice-5-4 for example, if one's using libreoffice 5.4.x behind of course...
from officeonlin-install.sh.
I am compiling as we speak. :-)
from officeonlin-install.sh.
did you specified the branch relative to the LO release ?
from officeonlin-install.sh.
Actually not, the demo is using version cp-5.3-13 but I am using the default.
from officeonlin-install.sh.
I have restarted the compile with the following clone.
git clone -b "distro/collabora/cp-5.3" "https://github.com/LibreOffice/core.git" "core"
from officeonlin-install.sh.
@Kassiematis So are the problems still there even after you fetched the project from core?
from officeonlin-install.sh.
The compile is still running.
from officeonlin-install.sh.
It is definitely an improvement with the different github branch. I can resize columns.
Row 1 and column A show their number and letter again. (that's how far I have tested)
Question is how to change the script to incorporate the clone command.
git clone -b "distro/collabora/cp-5.3" "https://github.com/LibreOffice/core.git" "/opt/libreoffice"
from officeonlin-install.sh.
from officeonlin-install.sh.
Thank you for the update, that's a great improvement!
So basically you cloned the new core in /opt/libreoffice folder and ran the officeonlin-install.sh script again? Or did you change some parameters in the script ?
from officeonlin-install.sh.
The script will not work as intended without some mayor changes.
I ran the commands
sudo -s
systemctl stop loolwsd.service
rm -r /opt/libreoffice
git clone -b "distro/collabora/cp-5.3" "https://github.com/LibreOffice/core.git" "/opt/libreoffice"
chown -R lool:lool /opt/libreoffice
cd /opt/libreoffice
sudo -Hu lool ./autogen.sh --without-help --without-myspell-dicts
sudo -Hu lool make
This is from the top of my head so beware of typos.
from officeonlin-install.sh.
@Kassiematis
What about limitation (10 Docs/20 Connections)?
Why you compiled it like that?
It is interesting to know if we can build it with no limitation.
from officeonlin-install.sh.
Only libreoffice gets compiled. Loolwsd is not changed at all so the limitation is still 100/200.
from officeonlin-install.sh.
You're right! @Kassiematis
from officeonlin-install.sh.
So you put in evidence that both loolwsd and LibreOffice should be compiled from synchronized branch
aka using master /master for both software π
so far the script uses libreoffice official releases (auto-find the latest release by default) and the git repo for loolwsd with master branch by default. and so we have found issue with this.
before doing some rework (which is not that big) just after Only one test (!!) we may need to test the other way:
use the official libreoffice release and use the loolwsd branch related to the release.
for example:
actual libreoffice latest release is 5.3.3 so test with setting lool_src_branch
to libreoffice-5-3
(latest commit 16 dec sic) and see if the problems are also solved.
my though is : if we switch to building libreoffice from master branch ,we're gonna have a bad time with temp broken builds and constantly changing dependencies. It will be a nightmare to maintain and support users.
I was not happy with using latest commit from master for loowsd here, But without proper release, it was hard to choose how to select best commits. We may have the beginning of an answer here: choose a branch set for the libreoffice correct version.
from officeonlin-install.sh.
I can confirm that the collabora branch is the way to go. It is maintained by the same people that develops for loolwsd. The differences between the master and collabora branch are significant and the master branch cannot be used in combination with loolwsd.
from officeonlin-install.sh.
I've tested branch libreoffice-5-3 but something seems broken in the loleafleat as it missing lots of js files.
so by default the test conclude we can't trust "synchronised branch" for getting a stable product with the current version of the script.
@Kassiematis can you elaborate about the collabora branch ? for LO and/or Lool ?
from officeonlin-install.sh.
Lool = https://github.com/LibreOffice/online.git
LO = https://github.com/LibreOffice/core/tree/distro/collabora/cp-5.3
from officeonlin-install.sh.
Ok I'm in.
I'll work this change
from officeonlin-install.sh.
The Collabora demo is using this branch for loolwsd. I will test this tommorow if that makes a difference with the master.
https://github.com/LibreOffice/online/tree/distro/collabora/collabora-online-2-1
This branch seems to follow the LO branch from Collabora. You can see comments like this with the commits.
Requires: Collabora Office 5.3-13
from officeonlin-install.sh.
I have compiled with the following branches.
loolwsd = distro/collabora/collabora-online-2-1
libreoffice = distro/collabora/cp-5.3
Which are the same as the Collabora demo uses. Everything works fine.
from officeonlin-install.sh.
Compiling with the following branches together also works fine.
loolwsd = https://github.com/LibreOffice/online/tree/libreoffice-5-4
libreoffice = https://github.com/LibreOffice/core/tree/libreoffice-5-4
only this directory has to be created and owner altered to lool
/usr/local/var/cache/libreoffice-online
from officeonlin-install.sh.
This is valuable information. Maybe its a good idea to pin a "kown/good working set" in the script. I already do this, as documented here:
https://github.com/husisusi/officeonlin-install.sh#versions
Would be good to make this "kown/good working set" the default and update versions with PRs if its approved?
from officeonlin-install.sh.
Nice π
only this directory has to be created and owner altered to lool
/usr/local/var/cache/libreoffice-online
had the same with libreoffice-5-3
It's a shame the libreoffice-5-3 branch of online seems broken (in my tests at least), The branch seems abandonned : last commit was last year also. Could appen again.
I think we should keep on collabora branches by default as you suggested
from officeonlin-install.sh.
Just wanted to inform you guys...
I just compiled from the script. It took 5 hours on a 4 core CPU i5 6500 series. I didn't change anything, I just ran it - and this is the final result:
Tested file:///opt/libreoffice/vcl/qa/cppunit/graphicfilter/data/bmp/fail/EDB-24743-1.bmp: Fail (0ms)
Testing file:///opt/libreoffice/vcl/qa/cppunit/graphicfilter/data/bmp/fail/EDB-24743-4.bmp:
Tested file:///opt/libreoffice/vcl/qa/cppunit/graphicfilter/data/bmp/fail/EDB-24743-4.bmp: Fail (0ms)
Testing file:///opt/libreoffice/vcl/qa/cppunit/graphicfilter/data/bmp/fail/crash-1.bmp:
Tested file:///opt/libreoffice/vcl/qa/cppunit/graphicfilter/data/bmp/fail/crash-1.bmp: Fail (1ms)
Testing file:///opt/libreoffice/vcl/qa/cppunit/graphicfilter/data/bmp/fail/nodict-compress.bmp:
Killed
No core file identified in directory /opt/libreoffice/workdir/CppunitTest/vcl_filters_test.test.core
To show backtraces for crashes during test execution,
enable core files with:
ulimit -c unlimited
Error: a unit test failed, please do one of:
make CppunitTest_vcl_filters_test CPPUNITTRACE="gdb --args"
# for interactive debugging on Linux
make CppunitTest_vcl_filters_test VALGRIND=memcheck
# for memory checking
make CppunitTest_vcl_filters_test DEBUGCPPUNIT=TRUE
# for exception catching
make[1]: *** [/opt/libreoffice/workdir/CppunitTest/vcl_filters_test.test] Error 1
/opt/libreoffice/solenv/gbuild/CppunitTest.mk:101: recipe for target '/opt/libreoffice/workdir/CppunitTest/vcl_filters_test.test' failed
make[1]: *** Waiting for unfinished jobs....
Makefile:263: recipe for target 'build' failed
make: *** [build] Error 2
In other words, script is failing in current state.
from officeonlin-install.sh.
Looks like the problem is with the Libreoffice compile. Found this on internet.
https://forums.freebsd.org/threads/60837/
Aalaesar is changing the script to use a different branch for LO. That will probably solve the problem.
from officeonlin-install.sh.
@Kassiematis Ok thanks, trying to compile again just to be sure. This time with 12 cores so it's going a bit faster. :) Will let you know.
from officeonlin-install.sh.
@Kassiematis @Payamch @husisusi
Aalaesar is changing the script to use a different branch for LO. That will probably solve the problem.>
Working branch here:
https://github.com/aalaesar/officeonlin-install.sh/tree/create_set
The "set" new feature is working on it's own and I'm testing inside the script at the moment.
it's still a little rough thought . I'll refine the changes once the script is more solid.
but further testing would be welcome π
from officeonlin-install.sh.
First test worked perfect.
LibreOffice Online
Deze versie van LibreOffice Online werk op basis van
LOOLWSD
2.1.2 (git hash: 51196ee)
LOKit
Collabora OfficeDev 5.3-16 (git hash: d134b1f)
from officeonlin-install.sh.
Nice π
What's your setup ?
What's your commit hash on the working branch ? (current commit is d022039)
Because I have refined some functions and now the script compile by default from the latest tag of the collabora set . (fd4bc0e)
But the hashes on your info pages are not the latest tags
LibreOffice core:
So maybe you changed the configuration or you kept on 6d38b63.
What do you think ? is the "build from latest tag" feature broken ?
from officeonlin-install.sh.
I dont know which version of the script i used, I downloaded the latest this morning. Have to check tomorrow.
from officeonlin-install.sh.
Just started new compile with the latest script.
Searching for a set named collabora...
core branch: distro/collabora/cp-5.3
core branch: distro/collabora/collabora-online-2-1
...
HEAD is now at e19a986 tdf#101885: fix crash in AccFrameSelector
from officeonlin-install.sh.
After compilation
LibreOffice Online
Deze versie van LibreOffice Online werk op basis van
LOOLWSD
2.1.2 (git hash: 4b03b9b)
LOKit
Collabora OfficeDev 5.3-16 (git hash: e19a986)
from officeonlin-install.sh.
π
Work fine by defaultπ
I'll try another set.
from officeonlin-install.sh.
I get an error because of this command in the script.
if pgrep -u lool loolwsd; then
No command 'pgrep:' found, did you mean:
Command 'pgrep' from package 'procps' (main)
pgrep:: command not found
from officeonlin-install.sh.
Thanks for the report.
This error append during the final test
what system do you use ?
I found pgrep pretty standard on Ubuntu 14.04, 16.04 & debian 8 so I didn't bother adding the package π
from officeonlin-install.sh.
I am using Ubuntu 16.04
from officeonlin-install.sh.
OK
well I suppose I'll add procps in the package list
so you may have the basic/test loolwsd instance running on your host now
old command to find loolwsd and kill it is ps -u lool | grep loolwsd
and ps -u lool -o pid,cmd | grep loolwsd |awk '{print $1}' | xargs kill
from officeonlin-install.sh.
closed by #69 ?
from officeonlin-install.sh.
Related Issues (20)
- Build error on Debian 9 HOT 1
- Multiple editors "crashes" loolwsd HOT 1
- Build error on Debian 10 HOT 2
- Build Error on Debian 10 HOT 3
- [SOLVED] Error Editing Docs with Γ€,ΓΆ,ΓΌ etc. HOT 6
- Build fails on rapsberry pi 4 running Raspian Buster HOT 1
- I build a docker image and pushed it to docker hub. HOT 3
- Error when creating document HOT 11
- openjdk error HOT 1
- Style sidebar HOT 2
- configure: error: unrecognized options: --disable-gstreamer-0-10, --disable-kde4 HOT 5
- In deleteTestDirectory function: remove Directory file:///tmp/????'?? HOT 2
- Collaboration in document bug? HOT 1
- openjdk-8-jdk : unknown command HOT 1
- ERR No DocBroker found, or DocBroker marked to be destroyed. Terminating session ToClient
- Could Node.js be updated to a supported version? HOT 6
- Build process on Ubuntu 18.04 not working HOT 5
- Debian 11 HOT 3
- can't configure multiple hosts in the new group and alias_group options HOT 3
- download as pdf not working HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from officeonlin-install.sh.