Git Product home page Git Product logo

Comments (8)

germa avatar germa commented on July 28, 2024

maybe we can structure it even further like e.g.

[Term]
id: XL:00000
name: Proteomics Standards Initiative cross-linking controlled vocabulary
def: "Proteomics Standards Initiative cross-linking controlled vocabulary." [PSI:XL]

[Term]
id: XL:00001
name: cross-linking entity
def: "Entity relevant to the domain of cross-linking in proteomics." [PSI:XL]
relationship: part_of XL:00000 Proteomics Standards Initiative cross-linking controlled vocabulary

[Term]
id: XL:00002
name: cross-linker
def: "Compound that can link one polymer chain to another." [PSI:XL]
is_a: XL:00001 ! cross-linking entity

[Term]
id: XL:00003
name: monofunctional cross-linker
def: "A cross-linker reagent with one reactive group." [PSI:XL]
is_a: XL:00002 ! cross-linker

[Term]
id: XL:00004
name: bifunctional cross-linker
def: "A cross-linker reagent with two reactive groups." [PSI:XL]
is_a: XL:00002 ! cross-linker

[Term]
id: XL:00005
name: homobifunctional cross-linker
def: "A cross-linker reagent with identical reactive groups at either end of the spacer arm." [PSI:XL]
is_a: XL:00004 ! bifunctional cross-linker

[Term]
id: XL:00006
name: heterobifunctional cross-linker
def: "A cross-linker reagent with different reactive groups at either end of the spacer arm." [PSI:XL]
is_a: XL:00004 ! bifunctional cross-linker

[Term]
id: XL:00007
name: photoreactive cross-linker
def: "A cross-linker reagent that becomes reactive when exposed to ultraviolet or visible light." [PSI:XL]
synonym: "non-selective cross-linker" EXACT [PSI:XL]
is_a: XL:00002 ! cross-linker

[Term]
id: XL:00008
name: trifunctional cross-linker
def: "A cross-linker reagent acting as label (e.g. biotin) transfer reagent." [PSI:XL]
is_a: XL:00002 ! cross-linker

[Term]
id: XL:00009
name: zero-length cross-linker
def: "A cross-linker reagent causing direct conjugation of carboxylates (-COOH) to primary amines (-NH2) without becoming part of the final crosslink (amide bond) between the target molecules." [PSI:XL]
is_a: XL:00002 ! cross-linker

from mzidentml.

lutzfischer avatar lutzfischer commented on July 28, 2024

Some points:

[Term]
id: XL:00003
name: monofunctional cross-linker
def: "A cross-linker reagent with one reactive group." [PSI:XL]
is_a: XL:00002 ! cross-linker

Don't think you could call that a cross-linker in the sense of XL:00002
Can we call it something along the lines of "cross-linker related PTM" or "cross-linker derived PTM"

Also

[Term]
id: XL:00008
name: trifunctional cross-linker
def: "A cross-linker reagent acting as label (e.g. biotin) transfer reagent." [PSI:XL]
is_a: XL:00002 ! cross-linker

trifunctional is ambiguous - you can have three groups on a cross-linker - but for some cross-linker that is used purification (e.g. biotin) on others that is just another group that is supposed to react with amino-acids (e.g. three nhs-ester groups.)

So maybe could name this to

[Term]
id: XL:00008
name: label transfer reagent
def: "label (e.g. biotin) transfer reagent." [PSI:XL]

and flag Terms with an has relationship.

Lastly

[Term]
id: XL:00005
name: homobifunctional cross-linker
def: "A cross-linker reagent with identical reactive groups at either end of the spacer arm." [PSI:XL]
is_a: XL:00004 ! bifunctional cross-linker

[Term]
id: XL:00006
name: heterobifunctional cross-linker
def: "A cross-linker reagent with different reactive groups at either end of the spacer arm." [PSI:XL]
is_a: XL:00004 ! bifunctional cross-linker

Can we rename these to homofunctional and heterofunctional? And not flag them as bifunctional?

Do we need to have separate categories for bifunctional? We have the number of reatcive sites as part of the cross-linker definition.

[Term]
id: XL:00000
name: Proteomics Standards Initiative cross-linking controlled vocabulary
def: "Proteomics Standards Initiative cross-linking controlled vocabulary." [PSI:XL]


[Term]
id: XL:00001
name: cross-linking entity
def: "Entity relevant to the domain of cross-linking in proteomics." [PSI:XL]
relationship: part_of XL:00000 Proteomics Standards Initiative cross-linking controlled vocabulary

[Term]
id: XL:00002
name: cross-linker
def: "Compound that can link two or more polymer chain." [PSI:XL]
is_a: XL:00001 ! cross-linking entity

[Term]
id: XL:00003
name: cross-linker related PTM
def: "A cross-linker reagent with one reactive group." [PSI:XL]
relationship: part_of XL:00000 Proteomics Standards Initiative cross-linking controlled vocabulary

[Term]
id: XL:00004
name: homo-functional cross-linker
def: "A cross-linker reagent with identical reactive groups at each end of the spacer arm." [PSI:XL]
is_a: XL:00002 ! cross-linker

[Term]
id: XL:00005
name: hetero-functional cross-linker
def: "A cross-linker reagent with at least two different reactive groups." [PSI:XL]
is_a: XL:00002 ! cross-linker

[Term]
id: XL:00006
name: photoreactive cross-linker
def: "A cross-linker reagent that becomes reactive when exposed to ultraviolet or visible light." [PSI:XL]
synonym: "non-selective cross-linker" EXACT [PSI:XL]
is_a: XL:00002 ! cross-linker

[Term]
id: XL:00007
name: label transfer reagent
def: "NOT SURE WHAT TO WRITE HERE" [PSI:XL]
relationship: part_of XL:00000 Proteomics Standards Initiative cross-linking controlled vocabulary

[Term]
id: XL:00008
name: zero-length cross-linker
def: "A cross-linker reagent causing direct conjugation without becoming part of the final crosslink  between the target molecules." [PSI:XL]
is_a: XL:00002 ! cross-linker

from mzidentml.

andrewrobertjones avatar andrewrobertjones commented on July 28, 2024

Proposal seems reasonable, @germa and @lutzfischer - please continue to work on this

Need to add lines to mapping file for linking to Unimod for regular mods and to XLMOD for these, so need appropriate branch node to link to. thanks Andy

from mzidentml.

germa avatar germa commented on July 28, 2024
  • Finished initial restructured version of XLMOD.obo
  • requested to include XLMOD.obo in OBOFoundry.github.io
    (see pull request OBOFoundry/OBOFoundry.github.io#284)
  • TODO: Include XLMOD.obo into the EBI Open Lookup Service

from mzidentml.

germa avatar germa commented on July 28, 2024

Had to change the identifiers from XL:nnnnn to XLMOD:nnnnn in order to avaoid name clashes, as reported by Chris Mungall, see OBOFoundry/OBOFoundry.github.io#284

from mzidentml.

edeutsch avatar edeutsch commented on July 28, 2024

okay, fine. This means all the XL example files will need to be changed.

from mzidentml.

andrewrobertjones avatar andrewrobertjones commented on July 28, 2024

@germa @edeutsch Can we now close this thread? The new OBO looks sensible to me

from mzidentml.

germa avatar germa commented on July 28, 2024

yes, the restructuring of xlmod.obo is finished

from mzidentml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.